WIP edits to AS3 changelog #5286
Conversation
CHANGELOG.md
Outdated
|
|
||
| - When using a non-serverless framework integration (Express, Fastify, Hapi, Koa, Micro, or Cloudflare), you now *must* call `await server.start()` before attaching the server to your framework. | ||
| * This method was introduced in v2.22 but was optional prior to Apollo Server 3. | ||
| * This does not apply to the core `apollo-server` library or to _serverless_ framework integrations. |
There was a problem hiding this comment.
I don't think "core" is right here: this isn't about apollo-server-core, it's about the "batteries-included" apollo-server which is a wrapper around apollo-server-express.
CHANGELOG.md
Outdated
| @@ -9,34 +9,89 @@ The version headers in this history reflect the versions of Apollo Server itself | |||
|
|
|||
| ## v3.0.0 (PRERELEASE) | |||
|
|
|||
| > The changes noted within this `v3.0.0` section have not been finalized. This section aims to track all changes that are going into the 3.0 release, but we will not claim that it is comprehensive until we have finalized the 3.0 release. | |||
| > The changes in this `v3.0.0` section have not been finalized. This section aims to track all changes that are going into the 3.0 release, but it is not comprehensive until the 3.0 release is finalized. | |||
There was a problem hiding this comment.
interesting, you don't like the active voice here? (also below I'm noticing I have "is being compiled to ES2020" which probably has a better wording.)
There was a problem hiding this comment.
Not so much active vs. passive as it is including "us" in the language, feels reasonable to keep it more neutrally perspectived, but this was far from a critical edit on my part 🤷♂️
|
I don't want to cause conflicts so I left CHANGELOG update out of #5287. The only thing needed there is a note that certain errors related to an inability to resolve the source of an operation (including APQ errors) now call |
| * This does not apply to the core `apollo-server` library or to _serverless_ framework integrations. | ||
| - `apollo-server-express` no longer officially supports using with the `connect` framework. | ||
| - We have not actively removed any `connect` compatibility code, and we do still test that it works with `connect`. However, we reserve the right to break that compatibility without a major version bump of this package (we will certainly note in this changelog if we do so). | ||
| - `apollo-server-lambda`: This package is now implemented as a wrapper around `apollo-server-express`. `createHandler`'s argument now has different options: |
There was a problem hiding this comment.
Another Lambda improvement is that we now have better support for running behind an ALB instead of just being API Gateway. (See #5291)
|
Let's make sure to get this one in as well #5294 |
|
some more that we need to include in this or remember for after: |
| - In certain error cases (mostly related to automated persisted queries), Apollo Server 2 skips firing `willSendResponse`. | ||
| - Renamed the `GraphQLService` interface to `GatewayInterface`. | ||
| - This interface is the type used to provide a federated gateway instance to Apollo Server. Its name has been changed to reduce ambiguity. |
There was a problem hiding this comment.
could note that the old name is still exported for backwards compatibility (so that we can have one version of @apollo/gateway that works with both server versions)
No description provided.