Rename GraphQLService to GatewayInterface #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GraphQLService` was a confusing name. It's not related to `GraphQLServiceContext` (which is the type of the argument to `serverWillStart`) nor is it related to "service", the old name for a graph in Studio... or "implementing service", the old name for a subgraph... It's the type of the `gateway` option, so giving it a gateway name seems reasonable. But we keep exporting the old name so that we can have builds of `@apollo/gateway` that work with both AS2 and AS3. Fixes #4919.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQLServicewas a confusing name. It's not related toGraphQLServiceContext(which is the type of the argument toserverWillStart) nor is it related to "service", the old name for agraph in Studio... or "implementing service", the old name for a
subgraph... It's the type of the
gatewayoption, so giving it agateway name seems reasonable.
But we keep exporting the old name so that we can have builds of
@apollo/gatewaythat work with both AS2 and AS3.Fixes #4919.