-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NettyHttpServerTest.testErrorBeforeRead #245
Labels
flaky tests
Unit tests are flaky
Comments
We haven't seen this problem for a long time. I will close the issue and we can reopen if necessary. |
doh, test doesn't fail anymore because it was disabled in https://github.pie.apple.com/servicetalk/servicetalk/pull/63 |
https://github.com/apple/servicetalk/pull/1525/checks?check_run_id=2655868413
|
local gradle build, macOS, JDK 16.0.2+7
|
local gradle build, macOS, JDK 8.0.302+8
|
Scottmitch
added a commit
to Scottmitch/servicetalk-1
that referenced
this issue
Sep 24, 2021
Motivation: NettyHttpServerTest.testErrorBeforeRead has the server intentionally write an error without first consuming the request content. The server may close the connection before the client is done writting and if that is the case a ClosedChannelException may be observed and fail the test. Modifications: - Allow ClosedChannelException when making a request Result: Fixes apple#245
Scottmitch
added a commit
that referenced
this issue
Sep 29, 2021
Motivation: NettyHttpServerTest.testErrorBeforeRead has the server intentionally write an error without first consuming the request content. The server may close the connection before the client is done writting and if that is the case a ClosedChannelException may be observed and fail the test. Modifications: - Allow ClosedChannelException when making a request Result: Fixes #245
Scottmitch
added a commit
that referenced
this issue
Sep 29, 2021
Motivation: NettyHttpServerTest.testErrorBeforeRead has the server intentionally write an error without first consuming the request content. The server may close the connection before the client is done writting and if that is the case a ClosedChannelException may be observed and fail the test. Modifications: - Allow ClosedChannelException when making a request Result: Fixes #245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
reproduced locally on macOS during Gradle build.
The text was updated successfully, but these errors were encountered: