NettyHttpServerTest.testErrorBeforeRead handle exception #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NettyHttpServerTest.testErrorBeforeRead has the server intentionally write an error without first consuming the request content. The server may close the connection before the client is done writting and if that is the case a ClosedChannelException may be observed and fail the test. Modifications: - Allow ClosedChannelException when making a request Result: Fixes apple#245
|
build failure attributed to #1579 |
chemicL
approved these changes
Sep 28, 2021
tkountis
approved these changes
Sep 28, 2021
Scottmitch
added a commit
that referenced
this pull request
Sep 29, 2021
Motivation: NettyHttpServerTest.testErrorBeforeRead has the server intentionally write an error without first consuming the request content. The server may close the connection before the client is done writting and if that is the case a ClosedChannelException may be observed and fail the test. Modifications: - Allow ClosedChannelException when making a request Result: Fixes #245
|
0.41 (a1fb483) |
idelpivnitskiy
approved these changes
Sep 29, 2021
| } catch (Throwable cause) { | ||
| // The server intentionally triggers an error when it writes, if this happens before all content is read | ||
| // the client may fail to write the request due to premature connection closure. | ||
| if (cause instanceof ExecutionException) { |
There was a problem hiding this comment.
Alternative approach can be to use "flushOnEnd" strategy by converting StreamingHttpRequest to an aggregated one and back. Then we don't need to worry about write failures on the client-side.
This approach also good. Either way is great to fix this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NettyHttpServerTest.testErrorBeforeRead has the server intentionally
write an error without first consuming the request content. The server
may close the connection before the client is done writting and if that
is the case a ClosedChannelException may be observed and fail the test.
Modifications:
Result:
Fixes #245