Make exception mapper filters public #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some users want to map exceptions earlier in the request processing pipeline in order to observe a real HTTP status code in other filters. Modifications: - Move `DefaultHttpServerBuilder.ExceptionMapperServiceFilter` -> `io.servicetalk.http.api.HttpExceptionMapperServiceFilter`; - Move `io.servicetalk.grpc.netty.CatchAllHttpServiceFilter` -> `io.servicetalk.grpc.api.GrpcExceptionMapperServiceFilter`; - Rename `CatchAllHttpServiceFilterTest` -> `GrpcExceptionMapperServiceFilterTest`; - Remove `io.servicetalk.grpc.netty.GrpcUtils` duplicate; Result: Users have access to our exception mapper implementations and can move them around other filters in the processing pipeline.
tkountis
approved these changes
Jan 11, 2022
|
Not sure that will be possible due to their differences in behavior. I'm preparing another PR to enhance the grpc mapper, it currently misses a few cases. |
idelpivnitskiy
added a commit
that referenced
this pull request
Jan 13, 2022
Motivation: Some users want to map exceptions earlier in the request processing pipeline in order to observe a real HTTP status code in other filters. Modifications: - Move `DefaultHttpServerBuilder.ExceptionMapperServiceFilter` -> `io.servicetalk.http.api.HttpExceptionMapperServiceFilter`; - Move `io.servicetalk.grpc.netty.CatchAllHttpServiceFilter` -> `io.servicetalk.grpc.api.GrpcExceptionMapperServiceFilter`; - Rename `CatchAllHttpServiceFilterTest` -> `GrpcExceptionMapperServiceFilterTest`; - Remove `io.servicetalk.grpc.netty.GrpcUtils` duplicate; - Add logging in `GrpcExceptionMapperServiceFilter`; Result: Users have access to our exception mapper implementations and can move them around other filters in the processing pipeline.
idelpivnitskiy
added a commit
that referenced
this pull request
Jan 13, 2022
Motivation: Some users want to map exceptions earlier in the request processing pipeline in order to observe a real HTTP status code in other filters. Modifications: - Move `DefaultHttpServerBuilder.ExceptionMapperServiceFilter` -> `io.servicetalk.http.api.HttpExceptionMapperServiceFilter`; - Move `io.servicetalk.grpc.netty.CatchAllHttpServiceFilter` -> `io.servicetalk.grpc.api.GrpcExceptionMapperServiceFilter`; - Rename `CatchAllHttpServiceFilterTest` -> `GrpcExceptionMapperServiceFilterTest`; - Remove `io.servicetalk.grpc.netty.GrpcUtils` duplicate; - Add logging in `GrpcExceptionMapperServiceFilter`; Result: Users have access to our exception mapper implementations and can move them around other filters in the processing pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some users want to map exceptions earlier in the request processing
pipeline in order to observe a real HTTP status code in other filters.
Modifications:
DefaultHttpServerBuilder.ExceptionMapperServiceFilter->io.servicetalk.http.api.HttpExceptionMapperServiceFilter;io.servicetalk.grpc.netty.CatchAllHttpServiceFilter->io.servicetalk.grpc.api.GrpcExceptionMapperServiceFilter;CatchAllHttpServiceFilterTest->GrpcExceptionMapperServiceFilterTest;io.servicetalk.grpc.netty.GrpcUtilsduplicate;GrpcExceptionMapperServiceFilter;Result:
Users have access to our exception mapper implementations and can move
them around other filters in the processing pipeline.