Make HttpLifecycleObserverServiceFilter public
#2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Server-side users may need to move `HttpLifecycleObserver` after other filters or apply it conditionally. Modifications: - Make `HttpLifecycleObserverServiceFilter` public; - Enhance `HttpLifecycleObserverServiceFilter` javadoc to clarify how its position in the filter chain may impact observed results; Result: Server-side users can place `HttpLifecycleObserver` at any position in the filter chain.
idelpivnitskiy
force-pushed
the
observer
branch
from
c2049c2 to
64a7e86
Compare
bondolo
approved these changes
Jan 13, 2022
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpServerBuilder.java
Outdated
Show resolved
Hide resolved
...k-http-netty/src/main/java/io/servicetalk/http/netty/HttpLifecycleObserverServiceFilter.java
Outdated
Show resolved
Hide resolved
...k-http-netty/src/main/java/io/servicetalk/http/netty/HttpLifecycleObserverServiceFilter.java
Outdated
Show resolved
Hide resolved
...k-http-netty/src/main/java/io/servicetalk/http/netty/HttpLifecycleObserverServiceFilter.java
Outdated
Show resolved
Hide resolved
…pServerBuilder.java Co-authored-by: Mike Duigou <[email protected]>
…/HttpLifecycleObserverServiceFilter.java Co-authored-by: Mike Duigou <[email protected]>
…/HttpLifecycleObserverServiceFilter.java Co-authored-by: Mike Duigou <[email protected]>
…/HttpLifecycleObserverServiceFilter.java Co-authored-by: Mike Duigou <[email protected]>
Scottmitch
approved these changes
Jan 13, 2022
idelpivnitskiy
added a commit
that referenced
this pull request
Jan 13, 2022
Motivation: Server-side users may need to move `HttpLifecycleObserver` after other filters or apply it conditionally. Modifications: - Make `HttpLifecycleObserverServiceFilter` public; - Enhance `HttpLifecycleObserverServiceFilter` javadoc to clarify how its position in the filter chain may impact observed results; Result: Server-side users can place `HttpLifecycleObserver` at any position in the filter chain.
idelpivnitskiy
added a commit
that referenced
this pull request
Jan 13, 2022
Motivation: Server-side users may need to move `HttpLifecycleObserver` after other filters or apply it conditionally. Modifications: - Make `HttpLifecycleObserverServiceFilter` public; - Enhance `HttpLifecycleObserverServiceFilter` javadoc to clarify how its position in the filter chain may impact observed results; Result: Server-side users can place `HttpLifecycleObserver` at any position in the filter chain.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Feb 16, 2022
Motivation: apple#2051 made `HttpLifecycleObserverServiceFilter` class public, but forgot to make its constructor public too. Modifications: - Make `HttpLifecycleObserverServiceFilter` constructor public; Result: Users can create an instance of `HttpLifecycleObserverServiceFilter` to use it with `appendServiceFilter(...)`.
idelpivnitskiy
added a commit
that referenced
this pull request
Feb 17, 2022
Motivation: #2051 made `HttpLifecycleObserverServiceFilter` class public, but forgot to make its constructor public too. Modifications: - Make `HttpLifecycleObserverServiceFilter` constructor public; Result: Users can create an instance of `HttpLifecycleObserverServiceFilter` to use it with `appendServiceFilter(...)`.
idelpivnitskiy
added a commit
that referenced
this pull request
Feb 17, 2022
Motivation: #2051 made `HttpLifecycleObserverServiceFilter` class public, but forgot to make its constructor public too. Modifications: - Make `HttpLifecycleObserverServiceFilter` constructor public; Result: Users can create an instance of `HttpLifecycleObserverServiceFilter` to use it with `appendServiceFilter(...)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Server-side users may need to move
HttpLifecycleObserverafter otherfilters or apply it conditionally.
Modifications:
HttpLifecycleObserverServiceFilterpublic;HttpLifecycleObserverServiceFilterjavadoc to clarify howits position in the filter chain may impact observed results;
Result:
Server-side users can place
HttpLifecycleObserverat any position inthe filter chain.
Depends on #2050