Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Removed the old flags from the codebase which have been rolled out #36256

Closed
AmanAgarwal041 opened this issue Sep 11, 2024 · 0 comments · Fixed by #36609
Closed

[Task]: Removed the old flags from the codebase which have been rolled out #36256

AmanAgarwal041 opened this issue Sep 11, 2024 · 0 comments · Fixed by #36609
Assignees
@AmanAgarwal041
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Task A simple Todo Tech Debt Issues or Tasks which are tech debts

Comments

@AmanAgarwal041
Copy link
Contributor

SubTasks

Flags list :

  1. ab_ds_binding_enabled
  2. ab_ds_schema_enabled
  3. ab_gsheet_schema_enabled
  4. ab_learnability_discoverability_collapse_all_except_data_enabled
  5. ab_learnability_ease_of_initial_use_enabled
  6. ab_mock_mongo_schema_enabled
  7. ab_start_with_data_default_enabled
  8. rollout_js_enabled_one_click_binding_enabled

Fix the cypress test cases as well.
Ref PRs :
CE PR : #36240
EE PR : https://github.com/appsmithorg/appsmith-ee/pull/5120
@AmanAgarwal041 AmanAgarwal041 added Task A simple Todo Query & JS Pod Issues related to the query & JS Pod labels Sep 11, 2024
@github-actions github-actions bot removed the Query & JS Pod Issues related to the query & JS Pod label Sep 11, 2024
@AmanAgarwal041 AmanAgarwal041 added Query & JS Pod Issues related to the query & JS Pod Tech Debt Issues or Tasks which are tech debts labels Sep 11, 2024
@github-actions github-actions bot removed the Query & JS Pod Issues related to the query & JS Pod label Sep 11, 2024
@AmanAgarwal041 AmanAgarwal041 mentioned this issue Sep 11, 2024
Closed
2 tasks
@AmanAgarwal041 AmanAgarwal041 added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label Sep 23, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod labels Sep 23, 2024
@AmanAgarwal041 AmanAgarwal041 self-assigned this Sep 30, 2024
@AmanAgarwal041 AmanAgarwal041 mentioned this issue Sep 30, 2024
Merged
2 tasks
rishabhrathod01 pushed a commit that referenced this issue Oct 7, 2024
@AmanAgarwal041
chore: removed old flags for airgap instances (#36609)
56e7f89 
## Description
Removed all the occurrences of listed flags in the codebase:

1. ab_ds_binding_enabled
2. ab_ds_schema_enabled
3. ab_gsheet_schema_enabled
4. ab_learnability_discoverability_collapse_all_except_data_enabled
5. ab_learnability_ease_of_initial_use_enabled
6. ab_mock_mongo_schema_enabled
7. ab_start_with_data_default_enabled
8. rollout_js_enabled_one_click_binding_enabled


Fixes #36256
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11177173738>
> Commit: bfbf6bb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11177173738&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 04 Oct 2024 10:31:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced test coverage for the Community Issues page, focusing on
pagination, search, filtering, and issue management.
- Improved functionality for adding new rows to table widgets, including
visibility controls and state validations.

- **Bug Fixes**
- Resolved issues related to the visibility of UI elements when adding
new rows and ensured accurate data reflection in the table.

- **Tests**
- Expanded tests for pagination, row selection, search functionality,
and filtering logic in table widgets.
- Added comprehensive assertions for client-side search and filtering
scenarios, including checks for modal visibility during issue
management.

- **Chores**
- Removed obsolete feature flags and streamlined logic for managing
feature flags across components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanAgarwal041 AmanAgarwal041

Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Task A simple Todo Tech Debt Issues or Tasks which are tech debts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: removed old flags for airgap instances appsmithorg/appsmith
1 participant
@AmanAgarwal041