chore: removed old flags for airgap instances

[AmanAgarwal041]

Description

Removed all the occurrences of listed flags in the codebase:

1. ab_ds_binding_enabled
2. ab_ds_schema_enabled
3. ab_gsheet_schema_enabled
4. ab_learnability_discoverability_collapse_all_except_data_enabled
5. ab_learnability_ease_of_initial_use_enabled
6. ab_mock_mongo_schema_enabled
7. ab_start_with_data_default_enabled
8. rollout_js_enabled_one_click_binding_enabled

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10809551611
Commit: 9c009d8
Cypress dashboard.
Tags: @tag.All
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

---

Wed, 11 Sep 2024 11:03:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Simplified handling of feature flags across various components, ensuring certain functionalities are always enabled.
  • Enhanced performance and maintainability of tests by removing unnecessary feature flag dependencies.

• Bug Fixes

  • Addressed issues related to feature flag management that could have impacted the execution of tests and widget behaviors.

• Chores

  • Cleaned up unused feature flags to streamline application configuration and improve clarity.

[coderabbitai]

Walkthrough

The pull request introduces significant modifications to the management of feature flags across the application's codebase. It removes several feature flags from test configurations, constants, and logical checks, leading to a more straightforward implementation. This restructuring simplifies the execution of tests, the configuration of components, and the overall approach to feature management, indicating a transition towards a more static model for certain functionalities.

Changes

Files	Change Summary
app/client/cypress/e2e/Regression/ClientSide/Autocomplete/...	Removed featureFlagIntercept calls, simplifying test setups for autocomplete suggestions.
app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/...	Removed featureFlagIntercept, changing feature flag management in one-click binding tests.
app/client/cypress/support/Objects/FeatureFlags.ts	Removed unused feature flags from FEATURE_FLAG and DEFAULT_FEATURE_FLAG_VALUE.
app/client/cypress/support/e2e.js	Removed properties ab_ds_binding_enabled and ab_ds_schema_enabled from addIndexedDBKey.
app/client/src/components/editorComponents/CodeEditor/...	Removed feature flag check for slash command menu display, simplifying logic.
app/client/src/components/editorComponents/.../PartialExportModal/...	Removed feature flags from defaultAppState, indicating deprecated features.
app/client/src/components/editorComponents/.../DatasourceDropdown/...	Removed feature flag check for JavaScript binding, simplifying binding logic.
app/client/src/constants/WalkthroughConstants.ts	Removed keys related to feature flags from FEATURE_WALKTHROUGH_KEYS.
app/client/src/pages/Editor/PropertyPane/...	Removed useFeatureFlag hook and related logic, passing hardcoded values instead.
app/client/src/widgets/MultiSelectWidgetV2/widget/...	Removed conditional check for feature flag in dynamicPropertyPathList, ensuring sourceData is always included.
app/client/src/widgets/SelectWidget/widget/...	Similar removal of conditional check for dynamicPropertyPathList, ensuring sourceData is included.
app/client/src/widgets/TableWidgetV2/widget/...	Removed conditional check for dynamicPropertyPathList, ensuring tableData is always included.
app/client/src/pages/Editor/DatasourceInfo/QueryTemplates.tsx	Removed walkthrough feature context and associated logic, streamlining component functionality.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Component

    User->>App: Request to display component
    App->>Component: Render component with static values
    Component-->>App: Display component
    App-->>User: Show component

Loading

🌟 In code we trust, with flags now gone,
Simplicity reigns, as we move along.
Features streamlined, logic so clear,
In this codebase, we have nothing to fear!
🎉 Embrace the change, let the old ways fade,
A cleaner path, in the progress we've made!

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 328067f and 9c009d8.

Files selected for processing (13)

• app/client/cypress/e2e/Regression/ClientSide/Autocomplete/PropertyPaneSlashCommand_spec.ts (2 hunks)
• app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/JSEnabledByDefaultExperiment_spec.ts (2 hunks)
• app/client/cypress/support/e2e.js (1 hunks)
• app/client/src/ce/entities/FeatureFlag.ts (2 hunks)
• app/client/src/components/editorComponents/CodeEditor/codeEditorUtils.ts (2 hunks)
• app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts (3 hunks)
• app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/useSource/useConnectToOptions.tsx (3 hunks)
• app/client/src/constants/WalkthroughConstants.ts (1 hunks)
• app/client/src/pages/Editor/DatasourceInfo/QueryTemplates.tsx (5 hunks)
• app/client/src/pages/Editor/PropertyPane/PropertyControlsGenerator.tsx (2 hunks)
• app/client/src/widgets/MultiSelectWidgetV2/widget/index.tsx (1 hunks)
• app/client/src/widgets/SelectWidget/widget/index.tsx (1 hunks)
• app/client/src/widgets/TableWidgetV2/widget/index.tsx (2 hunks)

Files skipped from review due to trivial changes (1)

• app/client/src/pages/Editor/DatasourceInfo/QueryTemplates.tsx

Files skipped from review as they are similar to previous changes (12)

• app/client/cypress/e2e/Regression/ClientSide/Autocomplete/PropertyPaneSlashCommand_spec.ts
• app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/JSEnabledByDefaultExperiment_spec.ts
• app/client/cypress/support/e2e.js
• app/client/src/ce/entities/FeatureFlag.ts
• app/client/src/components/editorComponents/CodeEditor/codeEditorUtils.ts
• app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts
• app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/useSource/useConnectToOptions.tsx
• app/client/src/constants/WalkthroughConstants.ts
• app/client/src/pages/Editor/PropertyPane/PropertyControlsGenerator.tsx
• app/client/src/widgets/MultiSelectWidgetV2/widget/index.tsx
• app/client/src/widgets/SelectWidget/widget/index.tsx
• app/client/src/widgets/TableWidgetV2/widget/index.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AmanAgarwal041]

Closing and opened the issue to tackle this problem : #36256