-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Updating cypress command #39056
ci: Updating cypress command #39056
Conversation
WalkthroughThis pull request updates the GitHub Actions workflow for Cypress tests. It replaces the predefined Changes
Sequence Diagram(s)sequenceDiagram
participant WF as Workflow
participant CMD as Custom Command
participant CYP as Cypress Tests
participant OUT as Output File
WF->>CMD: Execute Cypress test step\n(npx cypress-repeat-pro -n 3 ...)
CMD->>CYP: Run tests with specified specs & configuration
CYP-->>CMD: Return test results
CMD->>OUT: Write output to cy-repeat-summary.txt
CMD->>WF: Print summary file contents
Possibly related PRs
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-test-hosted.yml (1)
162-163
: Remove trailing spaces and fix comment spelling.Line 162 contains trailing spaces as flagged by YAMLlint, and the comment has a minor typo ("afterwords"). Please remove the trailing spaces and update the comment to read, for example:
# Delete the .git folder afterwards to utilize the environment values
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 162-162: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci-test-hosted.yml
(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/ci-test-hosted.yml
[error] 162-162: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/ci-test-hosted.yml (1)
250-256
: Review of the updated Cypress run command.The new step uses a custom command with
npx cypress-repeat-pro run -n 3 --rerun-failed-only ...
which enhances retry behavior for flaky tests. The inline settingNODE_ENV: development
and the subsequent output ofcy-repeat-summary.txt
appear to be correctly configured. Please verify that the chosen environment (development
) is intentional for hosted tests and that the summary file is generated as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-test-hosted.yml (1)
162-162
: Nitpick: Remove Trailing SpacesThere are trailing spaces at line 162. Please remove them to comply with YAML linting standards.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 162-162: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-test-custom-script.yml
(1 hunks).github/workflows/ci-test-hosted.yml
(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci-test-custom-script.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/ci-test-hosted.yml
[error] 162-162: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
🔇 Additional comments (1)
.github/workflows/ci-test-hosted.yml (1)
250-257
: Verify NODE_ENV and Cypress Command ConfigurationThe workflow now sets
NODE_ENV
directly to "development" inline before running the Cypress command. Please confirm that using "development" is the intended configuration for the hosted test environment. Additionally, the custom command usingnpx cypress-repeat-pro run -n 3 --rerun-failed-only
along with the summary output viacat cy-repeat-summary.txt
is a solid improvement for handling flaky tests. Ensure that the summary file is reliably generated during each run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
Hosted run also pass : https://github.com/appsmithorg/appsmith/actions/runs/13174366287
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13177264800
Commit: c801ca9
Cypress dashboard.
Tags:
@tag.All
Spec:
Thu, 06 Feb 2025 13:42:26 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit