ci: snowflake envs for credentials #39065
Conversation
WalkthroughThis pull request updates several GitHub Actions workflow files. The primary change is renaming environment variables for Snowflake credentials from the format Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant W as Workflow
participant T as Test Runner
U->>W: Trigger workflow (input: update_snapshot, run_count)
W->>W: Set environment variables (CYPRESS_SNOWFLAKE_*)
W->>T: Evaluate update_snapshot flag
alt Snapshot update is true
T->>T: Run tests with snapshot update
else
T->>T: Run tests normally
end
T->>W: Upload logs, snapshots, and cache results
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-test-limited-with-count.yml (1)
431-444: Conditional Cypress Test Execution Based on Snapshot Update Flag
The workflow now conditionally runs Cypress tests with snapshot updates ifupdate_snapshotis set to true. For improved consistency, consider renaming the inline environment variable fromCYPRESS_updateSnapshotstoCYPRESS_UPDATE_SNAPSHOTS(all uppercase) to match the naming style used elsewhere. For example:- CYPRESS_updateSnapshots=true npx cypress-repeat-pro run -n "${{ inputs.run_count }}" --force \ + CYPRESS_UPDATE_SNAPSHOTS=true npx cypress-repeat-pro run -n "${{ inputs.run_count }}" --force \This adjustment can help avoid potential confusion.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci-test-hosted.yml(1 hunks).github/workflows/ci-test-limited-with-count.yml(1 hunks).github/workflows/ci-test-limited.yml(1 hunks)
🔇 Additional comments (5)
.github/workflows/ci-test-hosted.yml (1)
248-250: Environment Variable Naming Update for Snowflake Credentials
The Snowflake credential variables are now renamed asCYPRESS_SNOWFLAKE_ACCOUNT_NAME,CYPRESS_SNOWFLAKE_USERNAME, andCYPRESS_SNOWFLAKE_PASSWORDto align with the Cypress testing context. Ensure that your repository’s secret configuration is updated accordingly..github/workflows/ci-test-limited.yml (1)
342-344: Consistent Credential Variable Renaming Across Workflows
The Snowflake environment variables have been updated to use theCYPRESS_prefix. Please verify that all references to these variables—including in secrets and downstream usage—are consistently updated throughout the codebase..github/workflows/ci-test-limited-with-count.yml (3)
17-31: New Input Parameters in Workflow Dispatch
New inputs (run_count,update_snapshot, andspecs_to_run) have been added in the workflow dispatch section. This enhances the configurability of test runs. Please ensure these parameters are validated and that their default values meet your testing requirements.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 23-23: wrong indentation: expected 8 but found 10
(indentation)
33-59: Enhanced Workflow Call Inputs
The inputs in theworkflow_callsection now mirror those inworkflow_dispatch, ensuring consistent behavior regardless of the trigger type. This uniformity improves usability when the workflow is invoked programmatically or manually.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 50-50: wrong indentation: expected 8 but found 10
(indentation)
426-428: Snowflake Credentials Renaming Consistency
The renaming of the Snowflake credential environment variables in this section aligns with other workflows. Ensure that the corresponding secrets (e.g.,SNOWFLAKE_ACCOUNT_NAME) are available and correctly mapped under the new names.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.SignIn"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13175660228
Commit: 414bca8
Cypress dashboard.
Tags:
@tag.SignInSpec:
Thu, 06 Feb 2025 09:38:32 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Chores
New Features