Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.yaml for v1.8 #10602

Closed
wants to merge 1 commit into from
Closed

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Oct 20, 2023

Description

Add the v1.8 items to release.yaml

@junkil-park junkil-park marked this pull request as ready for review October 20, 2023 19:58
@perryjrandall perryjrandall added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 20, 2023
@junkil-park junkil-park force-pushed the jpark/release-yaml-v1-8 branch from 82b8d38 to 100f504 Compare October 20, 2023 20:05
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@junkil-park junkil-park force-pushed the jpark/release-yaml-v1-8 branch from 100f504 to 4fe43a9 Compare October 20, 2023 21:49
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@junkil-park
Copy link
Contributor Author

@movekevin , @perryjrandall , @thepomeranian , how do we determine what items should go into the upgrade_framework step?

update_sequence:
- FeatureFlag:
enabled:
- Secp256k1ECDSAAuthenticator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem valid

Copy link
Contributor Author

@junkil-park junkil-park Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to single_sender_authenticator. @davidiw , could you confirm please?

Copy link
Contributor Author

@junkil-park junkil-park Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the feature index 33, the const names in Move and Rust are different:

Copy link
Contributor

@movekevin movekevin Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just fix that name on features.move in this same PR @junkil-park 🙏 ? It should say SINGLE_SENDER_AUTHENTICATOR as well

Copy link
Contributor Author

@junkil-park junkil-park Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@movekevin
Copy link
Contributor

@movekevin , @perryjrandall , @thepomeranian , how do we determine what items should go into the upgrade_framework step?

It's always been the same ones

@junkil-park junkil-park force-pushed the jpark/release-yaml-v1-8 branch from 4fe43a9 to 957a016 Compare October 23, 2023 20:21
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@junkil-park junkil-park changed the title Update release.yaml Update release.yaml for v1.8 Oct 24, 2023
- single_sender_authenticator
- name: enable_aggreators_v2_api
metadata:
title: "AIP-47: Aggregators V2: step 1: API"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @igor-aptos do we have a better name/title for this instead of step 1?

@junkil-park junkil-park force-pushed the jpark/release-yaml-v1-8 branch from 957a016 to 7f7d875 Compare October 25, 2023 00:39
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@junkil-park junkil-park force-pushed the jpark/release-yaml-v1-8 branch from 7f7d875 to d9dd3ca Compare October 25, 2023 14:52
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417

Compatibility test results for aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.2
compatibility::simple-validator-upgrade::liveness-check : committed: 3347 txn/s, latency: 6164 ms, (p50: 5100 ms, p90: 9800 ms, p99: 16000 ms), latency samples: 210920
2. Upgrading first Validator to new version: d9dd3ca27db176750cafd673eecc22994494c417
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1779 txn/s, latency: 16102 ms, (p50: 19200 ms, p90: 22200 ms, p99: 22600 ms), latency samples: 92520
3. Upgrading rest of first batch to new version: d9dd3ca27db176750cafd673eecc22994494c417
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1774 txn/s, latency: 16323 ms, (p50: 19200 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92260
4. upgrading second batch to new version: d9dd3ca27db176750cafd673eecc22994494c417
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3530 txn/s, latency: 8629 ms, (p50: 9900 ms, p90: 11500 ms, p99: 12300 ms), latency samples: 144760
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d9dd3ca27db176750cafd673eecc22994494c417

two traffics test: inner traffic : committed: 7992 txn/s, latency: 4896 ms, (p50: 4500 ms, p90: 5700 ms, p99: 22700 ms), latency samples: 3452800
two traffics test : committed: 100 txn/s, latency: 2337 ms, (p50: 2100 ms, p90: 2600 ms, p99: 8500 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.204, avg: 0.198", "QsPosToProposal: max: 0.386, avg: 0.184", "ConsensusProposalToOrdered: max: 0.607, avg: 0.579", "ConsensusOrderedToCommit: max: 0.519, avg: 0.489", "ConsensusProposalToCommit: max: 1.106, avg: 1.068"]
Max round gap was 1 [limit 4] at version 1883336. Max no progress secs was 4.162989 [limit 10] at version 1883336.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417

Compatibility test results for aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417 (PR)
Upgrade the nodes to version: d9dd3ca27db176750cafd673eecc22994494c417
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4319 txn/s, latency: 4792 ms, (p50: 4800 ms, p90: 7700 ms, p99: 8100 ms), latency samples: 241880
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> d9dd3ca27db176750cafd673eecc22994494c417 passed
Test Ok

@junkil-park
Copy link
Contributor Author

Migrates to #10679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants