-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release.yaml
for v1.8
#10602
Update release.yaml
for v1.8
#10602
Conversation
82b8d38
to
100f504
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
100f504
to
4fe43a9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@movekevin , @perryjrandall , @thepomeranian , how do we determine what items should go into the |
update_sequence: | ||
- FeatureFlag: | ||
enabled: | ||
- Secp256k1ECDSAAuthenticator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to single_sender_authenticator
. @davidiw , could you confirm please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the feature index 33, the const names in Move and Rust are different:
const SECP256K1_ECDSA_AUTHENTICATOR: u64 = 33; SINGLE_SENDER_AUTHENTICATOR = 33,
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just fix that name on features.move in this same PR @junkil-park 🙏 ? It should say SINGLE_SENDER_AUTHENTICATOR as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I fixed it in my PR: https://github.com/aptos-labs/aptos-core/pull/10455/files#diff-b408b1036a492541e5ad476af39f23f51018e91ce03a777b1d73654b513baaf3R267 (cc: @movekevin , @davidiw )
It's always been the same ones |
4fe43a9
to
957a016
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- single_sender_authenticator | ||
- name: enable_aggreators_v2_api | ||
metadata: | ||
title: "AIP-47: Aggregators V2: step 1: API" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @igor-aptos do we have a better name/title for this instead of step 1?
957a016
to
7f7d875
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7f7d875
to
d9dd3ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Migrates to #10679 |
Description
Add the v1.8 items to
release.yaml