Update release.yaml

[junkil-park]

Description

Update release.yaml for v1.8

[davidiw]

should we combine this was the secp? since it is the same feature flag.

[junkil-park]

@runtian-zhou also confirmed that they should be combined if they use the same feature flag.

By the way, is this a proper way to combine the information of the two steps? https://github.com/aptos-labs/aptos-core/pull/10679/files#diff-f0942a7d2fc980b7d9d90ec193ec4e9214cdb34c3e3c1d59fa7d5507325b1574R15

I am not sure if discussion_url: https://url1, https://url2 will end up generating a proper link to the discussions? (@movekevin , @perryjrandall , @runtian-zhou)

[junkil-park]

@kent-white confirmed that two discussion urls in one proposal would not work in UI. So, I added the links to the description field and kept only one link (for AIP-55) in the discussion_url field.
@davidiw , @movekevin , @perryjrandall , @runtian-zhou , please let me know if you have any comments or concern for this.

[movekevin]

All look correct

[github-actions]

❌ Forge suite framework_upgrade failure on aptos-node-v1.7.3 ==> b07fbf7ecb4ec52d21b5ac962520370acce26a63

Compatibility test results for aptos-node-v1.7.3 ==> b07fbf7ecb4ec52d21b5ac962520370acce26a63 (PR)
Upgrade the nodes to version: b07fbf7ecb4ec52d21b5ac962520370acce26a63
Test Failed: Retry due to pod aptos-node-2-validator-0 status PodStatus { conditions: Some([PodCondition { last_probe_time: None, last_transition_time: Some(Time(2023-10-27T19:38:36Z)), message: Some("0/120 nodes are available: 1 node(s) had volume node affinity conflict, 119 Insufficient cpu, 119 Insufficient memory. preemption: 0/120 nodes are available: 1 Preemption is not helpful for scheduling, 119 No preemption victims found for incoming pod.."), reason: Some("Unschedulable"), status: "False", type_: "PodScheduled" }]), container_statuses: None, ephemeral_container_statuses: None, host_ip: None, init_container_statuses: None, message: None, nominated_node_name: None, phase: Some("Pending"), pod_ip: None, pod_ips: None, qos_class: Some("Guaranteed"), reason: None, start_time: None }

Stack backtrace:
   0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/result.rs:1961:27
      aptos_forge::backend::k8s::stateful_set::wait_stateful_set::{{closure}}
             at ./testsuite/forge/src/backend/k8s/stateful_set.rs:69:5
      aptos_forge::backend::k8s::stateful_set::scale_stateful_set_replicas::{{closure}}
             at ./testsuite/forge/src/backend/k8s/stateful_set.rs:243:6
   1: <aptos_forge::backend::k8s::node::K8sNode as aptos_forge::interface::node::Node>::start::{{closure}}
             at ./testsuite/forge/src/backend/k8s/node.rs:137:84
   2: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/future/future.rs:125:9
      <aptos_forge::backend::k8s::swarm::K8sSwarm as aptos_forge::interface::swarm::Swarm>::upgrade_validator::{{closure}}
             at ./testsuite/forge/src/backend/k8s/swarm.rs:262:27
   3: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/future/future.rs:125:9
      aptos_testcases::batch_update::{{closure}}
             at ./testsuite/testcases/src/lib.rs:51:60
      tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/park.rs:283:63
      tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/coop.rs:107:5
      tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/coop.rs:73:5
      tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/park.rs:283:31
   4: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/context/blocking.rs:66:9
      tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/scheduler/multi_thread/mod.rs:87:13
      tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/context/runtime.rs:65:16
   5: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/scheduler/multi_thread/mod.rs:86:9
      tokio::runtime::runtime::Runtime::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.29.1/src/runtime/runtime.rs:313:50
   6: <aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest>::run
             at ./testsuite/testcases/src/framework_upgrade.rs:56:9
   7: aptos_forge::runner::Forge<F>::run::{{closure}}
             at ./testsuite/forge/src/runner.rs:481:42
      aptos_forge::runner::run_test
             at ./testsuite/forge/src/runner.rs:549:11
      aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:481:30
   8: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:403:11
      forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
   9: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys_common/backtrace.rs:135:18
  10: std::rt::lang_start::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:166:18
  11: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:284:13
      std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
      std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
      std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:48
      std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
      std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
      std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:20
  12: main
  13: __libc_start_main
  14: _start
Trailing Log Lines:
      std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
      std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:20
  12: main
  13: __libc_start_main
  14: _start


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:292"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-10679-1698435072-aptos-node-v1-7-3","timestamp":"2023-10-27T19:43:37.783468Z","message":"Deleting namespace forge-framework-upgrade-pr-10679: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:400"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-10679-1698435072-aptos-node-v1-7-3","timestamp":"2023-10-27T19:43:37.783499Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-10679"}

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed

Stack backtrace:
   0: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:501:13
   1: forge::run_forge
             at ./testsuite/forge-cli/src/main.rs:403:11
      forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
   2: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
      std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys_common/backtrace.rs:135:18
   3: std::rt::lang_start::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:166:18
   4: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:284:13
      std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
      std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
      std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:48
      std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
      std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
      std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
      std::rt::lang_start_internal
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:20
   5: main
   6: __libc_start_main
   7: _start
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                1/1     Running     0          8m3s
aptos-node-1-validator-0                1/1     Running     0          7m11s
aptos-node-2-validator-0                0/1     Pending     0          5m3s
aptos-node-3-validator-0                1/1     Running     0          10m
genesis-aptos-genesis-eforge151-nfs5x   0/1     Completed   0          11m

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on b07fbf7ecb4ec52d21b5ac962520370acce26a63

two traffics test: inner traffic : committed: 5866 txn/s, latency: 6663 ms, (p50: 6300 ms, p90: 8700 ms, p99: 13200 ms), latency samples: 2546140
two traffics test : committed: 100 txn/s, latency: 3056 ms, (p50: 2900 ms, p90: 3700 ms, p99: 7800 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.220, avg: 0.210", "QsPosToProposal: max: 0.227, avg: 0.179", "ConsensusProposalToOrdered: max: 0.662, avg: 0.629", "ConsensusOrderedToCommit: max: 0.568, avg: 0.544", "ConsensusProposalToCommit: max: 1.224, avg: 1.173"]
Max round gap was 1 [limit 4] at version 1136680. Max no progress secs was 3.873322 [limit 10] at version 1136680.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on aptos-node-v1.7.3 ==> b07fbf7ecb4ec52d21b5ac962520370acce26a63

Compatibility test results for aptos-node-v1.7.3 ==> b07fbf7ecb4ec52d21b5ac962520370acce26a63 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3738 txn/s, latency: 6217 ms, (p50: 6000 ms, p90: 9000 ms, p99: 10800 ms), latency samples: 194400
2. Upgrading first Validator to new version: b07fbf7ecb4ec52d21b5ac962520370acce26a63
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1781 txn/s, latency: 16097 ms, (p50: 19400 ms, p90: 22100 ms, p99: 22500 ms), latency samples: 92660
3. Upgrading rest of first batch to new version: b07fbf7ecb4ec52d21b5ac962520370acce26a63
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1774 txn/s, latency: 16385 ms, (p50: 18700 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92260
4. upgrading second batch to new version: b07fbf7ecb4ec52d21b5ac962520370acce26a63
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3378 txn/s, latency: 9329 ms, (p50: 10200 ms, p90: 13200 ms, p99: 13500 ms), latency samples: 135140
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> b07fbf7ecb4ec52d21b5ac962520370acce26a63 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking