Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing vector::replace and compiler-v2 vector depenency fix #15524

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Optimizing vector::replace and compiler-v2 vector depenency fix #15524

merged 2 commits into from
Dec 19, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Dec 6, 2024 •
edited
Loading

⏱️ 41m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩 
rust-move-tests 8m 🟥 
rust-move-tests 7m 🟥 
rust-cargo-deny 5m 🟩 🟩 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 
general-lints 2m 🟩 🟩 🟩 
semgrep/ci 1m 🟩 🟩 🟩 
file_change_determinator 30s 🟩 🟩 🟩 
permission-check 7s 🟩 🟩 🟩 
permission-check 6s 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/vector_replace_speedup branch from 9238595 to 735c047 Compare December 6, 2024 21:11
This was referenced Dec 6, 2024
Open
Merged
Merged
@igor-aptos Graphite App
Copy link
Contributor Author

igor-aptos commented Dec 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 6, 2024
Merged
Merged
@vineethk vineethk mentioned this pull request Dec 6, 2024
Closed
2 tasks
@igor-aptos igor-aptos changed the title Optimizing vector::replace with mem::replace Optimizing vector::replace with mem::replace with Dec 9, 2024
@igor-aptos igor-aptos changed the title Optimizing vector::replace with mem::replace with Optimizing vector::replace and compiler-v2 vector depenency fix Dec 9, 2024
@igor-aptos igor-aptos requested a review from brmataptos December 9, 2024 18:42
@igor-aptos
Copy link
Contributor Author

added changes from #15528 here

This was referenced Dec 12, 2024
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
@igor-aptos igor-aptos force-pushed the igor/vector_replace_speedup branch from dc5accd to 4bc4bab Compare December 16, 2024 22:22
@igor-aptos
Copy link
Contributor Author

@brmataptos - can you review this one - I've moved #15528 here and you already reviewed/approved it there.

@vineethk vineethk requested a review from rahxephon89 December 18, 2024 17:57
@igor-aptos igor-aptos enabled auto-merge (squash) December 18, 2024 18:06
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282 (PR)
1. Check liveness of validators at old version: 34025227eb5367c449bf9dae3cd226fe5c187904
compatibility::simple-validator-upgrade::liveness-check : committed: 14728.38 txn/s, latency: 2251.02 ms, (p50: 2000 ms, p70: 2200, p90: 3000 ms, p99: 11400 ms), latency samples: 486480
2. Upgrading first Validator to new version: 4bc4babe560c2ffda89e14f983e8e7a03d40f282
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6679.22 txn/s, latency: 4324.37 ms, (p50: 4700 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 120740
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6842.02 txn/s, latency: 4849.31 ms, (p50: 5200 ms, p70: 5300, p90: 5400 ms, p99: 5700 ms), latency samples: 228380
3. Upgrading rest of first batch to new version: 4bc4babe560c2ffda89e14f983e8e7a03d40f282
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5613.95 txn/s, latency: 5242.09 ms, (p50: 6000 ms, p70: 6200, p90: 6300 ms, p99: 6400 ms), latency samples: 108920
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5676.07 txn/s, latency: 5830.32 ms, (p50: 6400 ms, p70: 6500, p90: 6500 ms, p99: 6600 ms), latency samples: 194520
4. upgrading second batch to new version: 4bc4babe560c2ffda89e14f983e8e7a03d40f282
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11215.76 txn/s, latency: 2470.39 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3200 ms), latency samples: 195880
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11853.33 txn/s, latency: 2697.62 ms, (p50: 2800 ms, p70: 2900, p90: 3000 ms, p99: 3400 ms), latency samples: 384360
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4bc4babe560c2ffda89e14f983e8e7a03d40f282

two traffics test: inner traffic : committed: 14454.01 txn/s, latency: 2751.98 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3800 ms), latency samples: 5495740
two traffics test : committed: 99.97 txn/s, latency: 1407.08 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2200 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.770, avg: 1.589", "ConsensusProposalToOrdered: max: 0.331, avg: 0.297", "ConsensusOrderedToCommit: max: 0.310, avg: 0.296", "ConsensusProposalToCommit: max: 0.613, avg: 0.593"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 36522 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.60s no progress at version 2650385 (avg 0.60s) [limit 16].
Test Ok

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282 (PR)
Upgrade the nodes to version: 4bc4babe560c2ffda89e14f983e8e7a03d40f282
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1390.68 txn/s, submitted: 1393.57 txn/s, failed submission: 2.89 txn/s, expired: 2.89 txn/s, latency: 2220.70 ms, (p50: 2100 ms, p70: 2400, p90: 2900 ms, p99: 3300 ms), latency samples: 125280
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1402.97 txn/s, submitted: 1405.94 txn/s, failed submission: 2.97 txn/s, expired: 2.97 txn/s, latency: 2172.80 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4500 ms), latency samples: 122700
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 4bc4babe560c2ffda89e14f983e8e7a03d40f282 passed
Upgrade the remaining nodes to version: 4bc4babe560c2ffda89e14f983e8e7a03d40f282
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1636.83 txn/s, submitted: 1639.20 txn/s, failed submission: 2.37 txn/s, expired: 2.37 txn/s, latency: 2029.68 ms, (p50: 1800 ms, p70: 2100, p90: 2800 ms, p99: 3900 ms), latency samples: 138220
Test Ok

@igor-aptos igor-aptos merged commit 1381c93 into main Dec 19, 2024
85 of 88 checks passed
@igor-aptos igor-aptos deleted the igor/vector_replace_speedup branch December 19, 2024 05:09
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
@igor-aptos @georgemitenkov
Optimizing vector::replace and compiler-v2 vector depenency fix (#15524)
e88db57 
* Optimizing vector::replace with mem::replace

* [compiler-v2] Also include all dependencies of vector for compiler v2 from #15528

---------

Co-authored-by: Igor <[email protected]>
@igor-aptos igor-aptos mentioned this pull request Jan 7, 2025
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahxephon89 rahxephon89 rahxephon89 approved these changes

@vineethk vineethk vineethk approved these changes

@lightmark lightmark Awaiting requested review from lightmark

@runtian-zhou runtian-zhou Awaiting requested review from runtian-zhou

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@brmataptos brmataptos Awaiting requested review from brmataptos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-aptos @vineethk @rahxephon89