-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external unique state and verified external value #15577
base: igor/object_delete_and_recreate
Are you sure you want to change the base?
external unique state and verified external value #15577
Conversation
⏱️ 47m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
const ETYPE_MISMATCH: u64 = 4; | ||
const EWITNESS_MISMATCH: u64 = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error codes ETYPE_MISMATCH
and EWITNESS_MISMATCH
are both assigned the value 4
. To maintain clear error handling and debugging, these should be given unique values. Consider assigning EWITNESS_MISMATCH
a distinct error code, such as 5
.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
eb16207
to
7092a12
Compare
e030b17
to
102b5ee
Compare
7092a12
to
5cbb160
Compare
102b5ee
to
1f370b7
Compare
5cbb160
to
e5f2580
Compare
1f370b7
to
d31b557
Compare
e5f2580
to
57414cf
Compare
d31b557
to
d240a97
Compare
57414cf
to
700d668
Compare
d240a97
to
b312f2f
Compare
700d668
to
b8a9b02
Compare
b312f2f
to
e1f4a36
Compare
b8a9b02
to
e0c474e
Compare
e1f4a36
to
1ed9524
Compare
e0c474e
to
95d8c20
Compare
1ed9524
to
83d70dc
Compare
95d8c20
to
627e416
Compare
83d70dc
to
cafa331
Compare
627e416
to
38a36a4
Compare
cafa331
to
9803ece
Compare
38a36a4
to
a256323
Compare
9803ece
to
c1b057e
Compare
a256323
to
08ba3dd
Compare
c1b057e
to
986c655
Compare
08ba3dd
to
40b9b56
Compare
986c655
to
9fa1f94
Compare
40b9b56
to
3a13d1d
Compare
9fa1f94
to
91f4a33
Compare
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist