Agreement: Update arapp json file (#1190)

* Agreement: update arapp json file * Agreement: Add comment clarifying challenge role
aragon · Jul 6, 2020 · 94e1811 · 94e1811
1 parent 9b6d78f
commit 94e1811
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/apps/agreement/arapp.json b/apps/agreement/arapp.json
@@ -27,13 +27,6 @@
     }
   },
   "roles": [
-    {
-      "name": "Sign Agreement",
-      "id": "SIGN_ROLE",
-      "params": [
-        "Signer address"
-      ]
-    },
     {
       "name": "Change Agreement configuration",
       "id": "CHANGE_AGREEMENT_ROLE",

diff --git a/apps/agreement/contracts/Agreement.sol b/apps/agreement/contracts/Agreement.sol
@@ -62,6 +62,8 @@ contract Agreement is IAgreement, AragonApp {
     string internal constant ERROR_SUBMITTER_FINISHED_EVIDENCE = "AGR_SUBMITTER_FINISHED_EVIDENCE";
     string internal constant ERROR_CHALLENGER_FINISHED_EVIDENCE = "AGR_CHALLENGER_FINISHED_EVIDENCE";
 
+    // This role is checked against the disputable apps when users try to challenge disuptable actions. 
+    // Thus, it must be configured per disputable app. Please take a look at `canPerformChallenge` for reference.
     // bytes32 public constant CHALLENGE_ROLE = keccak256("CHALLENGE_ROLE");
     bytes32 public constant CHALLENGE_ROLE = 0xef025787d7cd1a96d9014b8dc7b44899b8c1350859fb9e1e05f5a546dd65158d;