Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agreement: Update arapp json file #1190

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Agreement: Update arapp json file #1190

merged 2 commits into from
Jul 6, 2020

Conversation

facuspagnuolo
Copy link
Contributor

No description provided.

@facuspagnuolo facuspagnuolo requested a review from sohkai July 6, 2020 14:32
@facuspagnuolo facuspagnuolo self-assigned this Jul 6, 2020
@auto-assign auto-assign bot requested review from bpierre and Evalir July 6, 2020 14:32
sohkai
sohkai approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Looking at the code, maybe we should also leave a comment for how we use the CHALLENGE_ROLE in this app :).

@facuspagnuolo facuspagnuolo merged commit 94e1811 into master Jul 6, 2020
@facuspagnuolo facuspagnuolo deleted the fix_agreement_arapp_json branch July 6, 2020 19:21
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@facuspagnuolo
Agreement: Update arapp json file (aragon#1190)
279a301 
* Agreement: update arapp json file

* Agreement: Add comment clarifying challenge role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

@bpierre bpierre Awaiting requested review from bpierre

@Evalir Evalir Awaiting requested review from Evalir

Assignees

@facuspagnuolo facuspagnuolo

Labels
component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facuspagnuolo @sohkai