Upgrade rxjs to v6 in token-manager app #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpierre
approved these changes
Mar 19, 2019
apps/token-manager/app/src/script.js
Outdated
| @@ -232,9 +220,6 @@ function loadTokenSettings(token) { | |||
|
|
|||
| function loadTokenSymbol(token) { | |||
There was a problem hiding this comment.
And similar to the other comments, we could probably remove loadTokenSymbol().
sohkai
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
👍 @2color Do you think it would make sense if we just changed all the single-emission observables in @aragon/api to return promises instead and release a new major version of it (v2.0.0) (aragon/aragon.js#264)? Then we can remove all the toPromise() and just use them natively as promises.
- remove first/take where the observable returns a single value and completes because of sendAndObserveResponse
2color
force-pushed
the
rxjs6-upgrade-token-manager
branch
from
949a0a0 to
1fabae5
Compare
For sure. |
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
* Import new package name * Add rxjs as an explicit dependency * Watch background script too * fixup! Watch background script too * Migrate script to use rxjs6 - remove first/take where the observable returns a single value and completes because of sendAndObserveResponse * Migrate app to use rxjs v6 * Use toPromise wherever possible
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Import new package name * Add rxjs as an explicit dependency * Watch background script too * fixup! Watch background script too * Migrate script to use rxjs6 - remove first/take where the observable returns a single value and completes because of sendAndObserveResponse * Migrate app to use rxjs v6 * Use toPromise wherever possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rxjsas a dependencyThis PR is in the same vein as #698