Voting: Upgrade rxjs to v6 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
approved these changes
Mar 20, 2019
apps/voting/app/src/script.js
Outdated
| .first() | ||
| .subscribe(vote => resolve(loadVoteDescription(marshallVote(vote)))) | ||
| }) | ||
| app |
2color
force-pushed
the
rxjs6-upgrade-voting
branch
from
89ec509 to
11958a2
Compare
2color
force-pushed
the
rxjs6-upgrade-voting
branch
from
11958a2 to
1313be8
Compare
1 similar comment
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Upgrade to rxjs6 and simplify with toPromise * Add watch mode for background script * Use toPromise whereever possible * fixup! Upgrade to rxjs6 and simplify with toPromise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rxjsas a dependencynative javascript datatypes
This PR is in the same vein as: