Hoist common dependencies #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
force-pushed
the
hoist-dependencies
branch
from
94279c8 to
db2bcd0
Compare
sohkai
force-pushed
the
hoist-dependencies
branch
from
5526141 to
580e309
Compare
This was referenced May 23, 2019
2color
added a commit
that referenced
this pull request
May 29, 2019
…t-api * token-manager-loading-state: Upgrade @aragon/ui to 0.40.1 Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871) Use a boolean for loading indicator Token Manager: update @aragon/api dependencies Token Manager: fix lint Token Manager: only use the SyncIndicator for the loading states (#873) Token Manager: fix loading indicator not being shown when syncing Upgrade aragon ui Handle custom events before contract events Remove unneeded import Update apps/token-manager/app/src/script.js Travis: optimizations and refactor to use build stages (#865) Update Travis CI badge (#866) Hoist common dependencies (#863) Reduce sync status in background script Add syncing states (faked for now)
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@izqui Not sure if we purposely didn't hoist the dependencies before, or if this was a lerna@2 to lerna@3 change (as far as I remember, we've never hoisted them?).
In any case, this speeds up the initial bootstrap immensely, and brings the fully installed repo to 1.6GB vs. ~7GB for the CI.
Local development installs are still ~6GB, because
@aragon/clidoesn't work when hoisted due to dependency clashes (see aragon/aragon-cli#477 for a potential fix).