Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: optimizations and refactor to use build stages #865

Merged
merged 5 commits into from
May 28, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented May 23, 2019

Refactors the Travis pipeline to be built in stages, so the longer-running coverage tasks only get kicked off after the tests pass.

It also moves the Finance app's coverage tests away from being expected to fail, because the coverage improvements in #863 have made the instrumentation much, much faster.

@sohkai sohkai requested review from izqui and facuspagnuolo May 23, 2019 10:59
@sohkai sohkai mentioned this pull request May 23, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 97.732% when pulling 3356c62 on optimize-travis into 580e309 on hoist-dependencies.

Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now :)

@sohkai sohkai force-pushed the optimize-travis branch from 3356c62 to e0a4d46 Compare May 27, 2019 19:56
@sohkai sohkai changed the base branch from hoist-dependencies to master May 27, 2019 19:56
@sohkai sohkai merged commit 268a4f3 into master May 28, 2019
@sohkai sohkai deleted the optimize-travis branch May 28, 2019 07:09
2color added a commit that referenced this pull request May 29, 2019
…ng-state

* origin/master:
  Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871)
  Travis: optimizations and refactor to use build stages (#865)
  Update Travis CI badge (#866)
  Hoist common dependencies (#863)
2color added a commit that referenced this pull request May 29, 2019
…t-api

* token-manager-loading-state:
  Upgrade @aragon/ui to 0.40.1
  Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871)
  Use a boolean for loading indicator
  Token Manager: update @aragon/api dependencies
  Token Manager: fix lint
  Token Manager: only use the SyncIndicator for the loading states (#873)
  Token Manager: fix loading indicator not being shown when syncing
  Upgrade aragon ui
  Handle custom events before contract events
  Remove unneeded import
  Update apps/token-manager/app/src/script.js
  Travis: optimizations and refactor to use build stages (#865)
  Update Travis CI badge (#866)
  Hoist common dependencies (#863)
  Reduce sync status in background script
  Add syncing states (faked for now)
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants