Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fixed 2.2.1 ganache-core version #276

Closed
wants to merge 1 commit into from
Closed

Using fixed 2.2.1 ganache-core version #276

wants to merge 1 commit into from

Conversation

macor161
Copy link
Contributor

Fixes #274

This is a temporary fix until we get to know exactly what in the new ganache-core version is causing the bug.

@kernelwhisperer
Copy link
Contributor

I think we can close this in favor of aragon/aragen#25 which will rebuild the snapshot using 2.3.1, therefore new users will have the correct dependency, and old users can do:
npm i -g @aragon/cli
aragon devchain --reset

thoughts @sohkai ?

@sohkai
Copy link
Contributor

sohkai commented Nov 30, 2018

@0x6431346e Actually we were debating about publishing a hotfix version with this merged, since 2.3.1 may have snapshot issues and we were having a difficult time generating it through the CI.

@kernelwhisperer
Copy link
Contributor

Looks like bingen published 5.2.1 with the pinned version 🎉.
Closing for #280
Thank you @macor161!

@bingen
Copy link
Contributor

bingen commented Dec 1, 2018

Yes, sorry, @macor161 I forgot you had already submitted that PR. But thanks anyway for your help!!

@bingen
Copy link
Contributor

bingen commented Dec 1, 2018

Btw, I opened a PR in ganache-core repo, not sure if that's the best way to fix it, but their tests are passing and our cli is working with it:
trufflesuite/ganache#239

@macor161
Copy link
Contributor Author

macor161 commented Dec 1, 2018

@bingen No problem at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in "Your first Aragon app" tutorial
4 participants