Fix LevelDB creation from previous snapshot

[bingen]

Wrong option for encoding-down.
Fixes #597

[davidmurdoch]

There appears to be no changes to the logic with the change. What is the change trying to accomplish?

[mikeseese]

@davidmurdoch there is a change in logic. the { valueEncoding: "json" } in the second branch of the conditional now is going into the encode function instead of the levelup function. I'm not sure if this is the correct usage or not however.

I think we should break this code into less one-liner changes. Breaking up the code would look like this:

Before

if (self.options.db) {
  const levelupOptions = { valueEncoding: "json" };
  levelup(self.options.db, levelupOptions, finishInitializing);
} else {
  const levelupOptions = { valueEncoding: "json" };
  const encodedCachedown = encode(cachedown(directory, filedown).maxSize(100));
  levelupdb(encodedCachedown, levelupOptions, finishInitializing);
}

After

if (self.options.db) {
  const levelupOptions = { valueEncoding: "json" };
  levelup(self.options.db, levelupOptions, finishInitializing);
} else {
  const encodeOptions = { valueEncoding: "json" };
  const levelupOptions = {};
  const encodedCachedown = encode(cachedown(directory, filedown).maxSize(100), encodeOptions);
  levelupdb(encodedCachedown, levelupOptions, finishInitializing);
}

[bingen]

The one-line thing was automatically formatted.

[davidmurdoch]

@seese, @bingen, ah, sorry I missed that change. Definitely prefer the readability of the PR's formatting, and @seese's improvements even more. We'll investigate further this week!

[bingen]

Ok, thanks @davidmurdoch
Another way our issue gets fixed is just removing encoding-down. That was my first attempt, but then I thought that maybe it is needed for some other use case I'm missing. I opened the PR for you to have a look: #240 Feel free to close it if encoding-down is really needed.
I'll change the formatting to @seesemichaelj way.

[davidmurdoch]

Fixed in 994f0a6

[bingen]

Thanks @davidmurdoch , nice to have this fixed. Is it a new version planned to be published to npm soon? It would be useful to fix our dependencies.

[davidmurdoch]

@bingen I am hoping to release tomorrow, however, in pre-release testing I may have uncovered some new issues that may postpone the release.