Rpc Messenger: dedupe message bus across requests #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
approved these changes
Apr 9, 2019
2color
added a commit
to 2color/aragon.js
that referenced
this pull request
Apr 26, 2019
…th-cache * origin/master: (29 commits) Update README.md (aragon#291) Wrapper: clarify comments about forwarding path finding strategy (aragon#289) Split quick start doc from intro (aragon#287) @aragon/wrapper 5.0.0-rc.2 wrapper: prettify setApp() descriptions (aragon#284) wrapper: fix callsscripts decoding (aragon#283) Wrapper: add installedRepos observable (aragon#268) fix: avoid infinitely looping through forwarders when looking for a transaction path (aragon#285) wrapper: enforce message to sign is string (aragon#282) api: v1.1.0 rpc-messenger: v1.1.0 feat: @aragon/wrapper api cleanup (aragon#279) Wrapper: handle SetApp for updated apps (aragon#267) feat: Add message signing (aragon#276) Wrapper: don't assign initializationBlock on non-kernel proxies when unneeded (aragon#266) chore: ignore package-lock.jsons (aragon#280) API: propagate errors to single-response APIs (aragon#277) Rpc Messenger: dedupe message bus across requests (aragon#278) Fix: changes after review (aragon#274) Docs update: include react api, aragon app architecture & fixes (aragon#271) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to create a new listener on the target each time
provider.messages()was called, due to thefromEvent().Now these requests are deduped and the results are multicasted to subscribers.