Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce typeof message to sign is string #282

Merged
merged 5 commits into from
Apr 16, 2019
Merged

enforce typeof message to sign is string #282

merged 5 commits into from
Apr 16, 2019

Conversation

Schwartz10
Copy link
Contributor

No description provided.

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️

@sohkai
Copy link
Contributor

sohkai commented Apr 16, 2019

Moved the error handling logic to signMessage(), since it's exposed to @aragon/wrapper consumers, and added some tests for the observable :).

@sohkai sohkai merged commit 94ec00a into aragon:master Apr 16, 2019
2color added a commit that referenced this pull request Apr 17, 2019
* origin/master:
  Wrapper: add installedRepos observable (#268)
  fix: avoid infinitely looping through forwarders when looking for a transaction path (#285)
  wrapper: enforce message to sign is string (#282)
  api: v1.1.0
  rpc-messenger: v1.1.0
2color added a commit to 2color/aragon.js that referenced this pull request Apr 26, 2019
…th-cache

* origin/master: (29 commits)
  Update README.md (aragon#291)
  Wrapper: clarify comments about forwarding path finding strategy (aragon#289)
  Split quick start doc from intro (aragon#287)
  @aragon/wrapper 5.0.0-rc.2
  wrapper: prettify setApp() descriptions (aragon#284)
  wrapper: fix callsscripts decoding (aragon#283)
  Wrapper: add installedRepos observable (aragon#268)
  fix: avoid infinitely looping through forwarders when looking for a transaction path (aragon#285)
  wrapper: enforce message to sign is string (aragon#282)
  api: v1.1.0
  rpc-messenger: v1.1.0
  feat: @aragon/wrapper api cleanup (aragon#279)
  Wrapper: handle SetApp for updated apps (aragon#267)
  feat: Add message signing (aragon#276)
  Wrapper: don't assign initializationBlock on non-kernel proxies when unneeded (aragon#266)
  chore: ignore package-lock.jsons (aragon#280)
  API: propagate errors to single-response APIs (aragon#277)
  Rpc Messenger: dedupe message bus across requests (aragon#278)
  Fix: changes after review (aragon#274)
  Docs update: include react api, aragon app architecture & fixes (aragon#271)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants