Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common components #615

Merged
merged 22 commits into from
Mar 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9494073
AppLayout: refactor api
AquiGorka Feb 20, 2019
f36a5d1
MenuButton: refactor to use button icon and icon menu
AquiGorka Feb 15, 2019
ff95c4e
Home: refactor to use app layout
AquiGorka Feb 13, 2019
6195163
Apps: refactor to use app layout
AquiGorka Feb 13, 2019
c671711
Settings: refactor to use app layout
AquiGorka Feb 13, 2019
2d16032
Permissions: refactor to use app view
AquiGorka Feb 13, 2019
7651c10
AddPermissionButton: refactor to use button icon and plus icon
AquiGorka Feb 13, 2019
178b42e
ViewDetailsButton: refactor to use button icon and icon arrow right
AquiGorka Feb 13, 2019
6b95d8b
EmptyBlock: fix margins, borders and border radius for responsive view
AquiGorka Feb 13, 2019
4b5536e
Table: refactor to use no side borders prop
AquiGorka Feb 13, 2019
2a3465d
EntityRow: refactor to use common first and last styled table cells
AquiGorka Feb 15, 2019
5f42ab5
EntityRow: update button prop
AquiGorka Feb 20, 2019
5ef51b7
Section: update h1 margin
AquiGorka Feb 19, 2019
f1122f6
AppPermissions: add no side borders table prop
AquiGorka Feb 21, 2019
b7c94d4
AppRoles: add no side borders table prop
AquiGorka Feb 21, 2019
68beb5e
EntityPermissions: add no side borders table prop
AquiGorka Feb 21, 2019
5f0205d
BrowseByEntity: add no side borders table prop
AquiGorka Feb 21, 2019
e3ee17b
Fix the navigation bar in Permissions
bpierre Feb 27, 2019
ba8595b
Permissions: use AppLayout
bpierre Feb 28, 2019
294f8b1
ESLint fixes
bpierre Feb 28, 2019
a0c86a0
Remove unused imports
bpierre Feb 28, 2019
3c7e17d
Update aragon ui version number
AquiGorka Mar 4, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
],
"dependencies": {
"@aragon/templates-tokens": "^1.1.1",
"@aragon/ui": "^0.31.0",
"@aragon/ui": "^0.32.0",
"@aragon/wrapper": "^3.0.0-beta.5",
"@babel/polyfill": "^7.0.0",
"bn.js": "4.11.6",
Expand Down
72 changes: 22 additions & 50 deletions src/apps/Apps/Apps.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,27 @@ import React from 'react'
import PropTypes from 'prop-types'
import styled from 'styled-components'
import {
Card,
Button,
Badge,
Text,
Button,
Card,
SafeLink,
theme,
Text,
breakpoint,
colors,
theme,
unselectable,
font,
breakpoint,
Viewport,
} from '@aragon/ui'
import AppLayout from '../../components/AppLayout/AppLayout'
import MenuButton from '../../components/MenuPanel/MenuButton'

import defaultIcon from './icons/default.svg'
import payrollIcon from './icons/payroll.svg'
import espressoIcon from './icons/espresso.svg'

class Apps extends React.Component {
static propTypes = {
onMessage: PropTypes.func,
onMessage: PropTypes.func.isRequired,
}

handleMenuPanelOpen = () => {
this.props.onMessage({
data: { from: 'app', name: 'menuPanel', value: true },
Expand All @@ -34,27 +32,20 @@ class Apps extends React.Component {
render() {
return (
<AppLayout
title={
<AppBarTitle>
<Viewport>
{({ below }) =>
below('medium') && (
<MenuButton onClick={this.handleMenuPanelOpen} />
)
}
</Viewport>
<AppBarLabel>Apps</AppBarLabel>
</AppBarTitle>
}
endContent={
<DevPortalAnchor
mode="strong"
href="https://hack.aragon.org/"
target="_blank"
>
Create a new app
</DevPortalAnchor>
}
title="Apps"
onMenuOpen={this.handleMenuPanelOpen}
mainButton={{
button: (
<DevPortalAnchor
mode="strong"
href="https://hack.aragon.org/"
target="_blank"
>
Create a new app
</DevPortalAnchor>
),
}}
smallViewPadding={20}
>
<Content>
<p>
Expand Down Expand Up @@ -97,31 +88,12 @@ class Apps extends React.Component {
}
}

const AppBarTitle = styled.span`
display: flex;
align-items: center;
margin-left: -30px;
`

const AppBarLabel = styled.span`
margin-left: 8px;
${font({ size: 'xxlarge' })};

${breakpoint(
'medium',
`
margin-left: 24px;
`
)};
`

const DevPortalAnchor = styled(Button.Anchor)`
margin-right: 20px;
display: block;
`

const Content = styled.div`
padding: 30px;

> h1 {
margin: 30px 0;
font-weight: 600;
Expand Down
41 changes: 0 additions & 41 deletions src/apps/Permissions/AddPermissionButton.js

This file was deleted.

48 changes: 28 additions & 20 deletions src/apps/Permissions/AppPermissions.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'
import PropTypes from 'prop-types'
import { Button, Table, TableRow, Text } from '@aragon/ui'
import { Button, Table, TableRow, Text, Viewport } from '@aragon/ui'
import IdentityBadge from '../../components/IdentityBadge'
import { TableHeader, TableCell, FirstTableCell, LastTableCell } from './Table'
import { PermissionsConsumer } from '../../contexts/PermissionsContext'
Expand Down Expand Up @@ -39,25 +39,33 @@ class AppPermissions extends React.PureComponent {
: 'No permissions set.'}
</EmptyBlock>
) : (
<Table
header={
<TableRow>
<TableHeader title="Action" style={{ width: '20%' }} />
<TableHeader title="Allowed for" />
<TableHeader />
</TableRow>
}
>
{appPermissions.map(({ role, entity }, i) => (
<Row
key={i}
role={role}
entity={entity}
proxyAddress={address}
onRevoke={revokePermission}
/>
))}
</Table>
<Viewport>
{({ below }) => (
<Table
noSideBorders={below('medium')}
header={
<TableRow>
<TableHeader
title="Action"
style={{ width: '20%' }}
/>
<TableHeader title="Allowed for" />
<TableHeader />
</TableRow>
}
>
{appPermissions.map(({ role, entity }, i) => (
<Row
key={i}
role={role}
entity={entity}
proxyAddress={address}
onRevoke={revokePermission}
/>
))}
</Table>
)}
</Viewport>
)}
</Section>
<EntityPermissions
Expand Down
46 changes: 27 additions & 19 deletions src/apps/Permissions/AppRoles.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'
import PropTypes from 'prop-types'
import { Button, Table, TableRow, Text } from '@aragon/ui'
import { Button, Table, TableRow, Text, Viewport } from '@aragon/ui'
import { AppType, EthereumAddressType } from '../../prop-types'
import { TableHeader, TableCell, FirstTableCell, LastTableCell } from './Table'
import IdentityBadge from '../../components/IdentityBadge'
Expand Down Expand Up @@ -44,24 +44,32 @@ class AppRoles extends React.PureComponent {
{loading || roles.length === 0 ? (
<EmptyBlock>{loading ? loadingLabel : emptyLabel}</EmptyBlock>
) : (
<Table
header={
<TableRow>
<TableHeader title="Action" style={{ width: '20%' }} />
<TableHeader title="Managed by" />
<TableHeader />
</TableRow>
}
>
{roles.map(({ role, manager }, i) => (
<RoleRow
key={i}
role={role}
manager={manager}
onManage={this.handleManageRole}
/>
))}
</Table>
<Viewport>
{({ below }) => (
<Table
noSideBorders={below('medium')}
header={
<TableRow>
<TableHeader
title="Action"
style={{ width: '20%' }}
/>
<TableHeader title="Managed by" />
<TableHeader />
</TableRow>
}
>
{roles.map(({ role, manager }, i) => (
<RoleRow
key={i}
role={role}
manager={manager}
onManage={this.handleManageRole}
/>
))}
</Table>
)}
</Viewport>
)}
</Section>
)
Expand Down
11 changes: 7 additions & 4 deletions src/apps/Permissions/EmptyBlock.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@ import styled from 'styled-components'
import { Card, breakpoint } from '@aragon/ui'

const EmptyBlock = styled(Card)`
margin: 30px;
display: flex;
align-items: center;
justify-content: center;
width: auto;
width: 100%;
height: 180px;
border-left-width: 0;
border-right-width: 0;
border-radius: 0;

${breakpoint(
'medium',
`
margin: 0;
width: 100%;
border-left-width: 1px;
border-right-width: 1px;
border-radius: 3px;
`
)}
`
Expand Down
56 changes: 32 additions & 24 deletions src/apps/Permissions/EntityPermissions.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'
import PropTypes from 'prop-types'
import { Button, Table, TableRow, Text } from '@aragon/ui'
import { Button, Table, TableRow, Text, Viewport } from '@aragon/ui'
import { TableHeader, TableCell, FirstTableCell, LastTableCell } from './Table'
import Section from './Section'
import EmptyBlock from './EmptyBlock'
Expand Down Expand Up @@ -40,30 +40,38 @@ class EntityPermissions extends React.PureComponent {
{loading ? loadPermissionsLabel : noPermissionsLabel}
</EmptyBlock>
) : (
<Table
header={
<TableRow>
<TableHeader title="Action" style={{ width: '20%' }} />
<TableHeader title="On app" />
<TableHeader />
</TableRow>
}
>
{roles.map(
({ role, roleBytes, roleFrom, proxyAddress }, i) => (
<Row
key={i}
entityAddress={address}
id={(role && role.id) || 'Unknown'}
roleBytes={roleBytes}
action={(role && role.name) || 'Unknown'}
app={roleFrom.app}
proxyAddress={proxyAddress}
onRevoke={revokePermission}
/>
)
<Viewport>
{({ below }) => (
<Table
noSideBorders={below('medium')}
header={
<TableRow>
<TableHeader
title="Action"
style={{ width: '20%' }}
/>
<TableHeader title="On app" />
<TableHeader />
</TableRow>
}
>
{roles.map(
({ role, roleBytes, roleFrom, proxyAddress }, i) => (
<Row
key={i}
entityAddress={address}
id={(role && role.id) || 'Unknown'}
roleBytes={roleBytes}
action={(role && role.name) || 'Unknown'}
app={roleFrom.app}
proxyAddress={proxyAddress}
onRevoke={revokePermission}
/>
)
)}
</Table>
)}
</Table>
</Viewport>
)}
</Section>
)
Expand Down
2 changes: 1 addition & 1 deletion src/apps/Permissions/Home/BrowseByApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const Apps = styled.div`
display: grid;
grid-gap: 10px;
grid-template-columns: minmax(150px, 1fr) minmax(150px, 1fr);
margin: 0 30px;
margin: 0 20px;

${breakpoint(
'medium',
Expand Down
Loading