Refactor common components #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
force-pushed
the
feature/update-common-components
branch
3 times, most recently
from
5576399 to
d864c8a
Compare
AquiGorka
force-pushed
the
feature/update-common-components
branch
11 times, most recently
from
c3e627d to
0a4b585
Compare
These changes also update the navigation items to set the padding for responsive behavior and bring back animating the titles when navigating throught the permissions items.
AquiGorka
force-pushed
the
feature/update-common-components
branch
from
0a4b585 to
5f0205d
Compare
AppLayout now accept navigation items.
sohkai
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
👍 Looking good; I assume we'll need to a do a bit of light upgrading for @aragon/[email protected]?
bpierre
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
I assume we'll need to a do a bit of light upgrading for
@aragon/[email protected]?
Yes, it should be the only remaining thing to do in this PR ✅ ✅ ✅
|
@AquiGorka @bpierre Noticed this on the new version on chrome in settings:
|
|
Will look into it |
2color
added a commit
that referenced
this pull request
Apr 3, 2019
* origin/master: (56 commits) Identity - Improve LocalIdentityBadge (#673) Menu panel footer separator (#666) fix(MenuPanel): avoid clickable margin above system apps toggle (#671) Local identities (#656) MenuPanel: add toggle animation to show/hide system apps (#658) Add github workflow for linting/building (#663) Permissions: added system and background app labels (#650) Use the same component to render every app icon (#655) chore: add all contributors and contributing guidelines (#649) Manage the menu button using messages + prevent re-mounting on resize (#651) Update melon (#647) Apps <> System apps separator (#648) Upgrade lint-staged (#646) fix: always leave Kernel as first app (#645) fix: avoid assigning a registry tag if app is not on a registry (#644) chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639) DaoSettings: add bottom margin on app items (#638) Refactor common components (#615) Enforce MenuPanel’s width (#636) Menu panel swipe open close (#606) ...
2color
added a commit
that referenced
this pull request
Apr 3, 2019
* origin/master: (55 commits) Identity - Improve LocalIdentityBadge (#673) Menu panel footer separator (#666) fix(MenuPanel): avoid clickable margin above system apps toggle (#671) Local identities (#656) MenuPanel: add toggle animation to show/hide system apps (#658) Add github workflow for linting/building (#663) Permissions: added system and background app labels (#650) Use the same component to render every app icon (#655) chore: add all contributors and contributing guidelines (#649) Manage the menu button using messages + prevent re-mounting on resize (#651) Update melon (#647) Apps <> System apps separator (#648) Upgrade lint-staged (#646) fix: always leave Kernel as first app (#645) fix: avoid assigning a registry tag if app is not on a registry (#644) chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639) DaoSettings: add bottom margin on app items (#638) Refactor common components (#615) Enforce MenuPanel’s width (#636) Menu panel swipe open close (#606) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes use the new common components from
aragon/ui(or at least till PRs 318-322 are merged).Includes fix for
Permissions'sEmptyBlock's margins and borders.** Based of
use-viewportbecause a) Viewport rocks and b) it usesViewportRefs:
MenuButton&AppViewPlusButtonArrowRightButtonEmptyBlock