-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aragonCLI documentation #99
Conversation
I think this makes sense; we could move the current app tutorial to be under this new section as the first guide (leaving the "your first app" tutorial in the header as is)? |
Yes! Great idea |
I like it! 💯 |
docs/cli-apm-commands.md
Outdated
|
||
## aragon apm grant | ||
|
||
Grant an address (group of addresses) permission to create new versions in the package define in the `arapp.json` file, by interacting directly with the ACL, without performing transaction pathing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package define in the
defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!! 🚀
(I haven't reviewed the guides/faq sections yet, let me know when they are ready)
Also, there's something weird with the colors of the code snippets on my machine.
We might need to mark them with ```sh
Daniel's review Co-Authored-By: 0xGabi <[email protected]>
@0x6431346e You are right about the colors in code snippets. I tried with ```sh and the code are only grey colored. @delfipolito Are the code snippets color coding related with the style of the website? |
Is ready for review. I decided to include Frame guide in the next iteration. All feedback is welcome 😄 |
@0xGabi I didn't change anything about the code snippets on the redesign PR, so they should look the same |
docs/guides-custom-deploy.md
Outdated
@@ -20,7 +20,7 @@ npm install -g @aragon/cli | |||
|
|||
In order to deploy to rinkeby or mainnet using the CLI you will either need to use a hardware wallet with [Frame](https://frame.sh) or configure aragonCLI to [sign transactions using a private key](/docs/cli-faq.html#set-a-private-key). | |||
|
|||
If you decide to [use frame](guides-use-frame.md), just add `--use-frame` to any of these commands. | |||
If you decide to use frame, just add `--use-frame` to any of these commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Frame with uppercase F
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If you want to learn how use environments in practice check the guides to learn [how to publish in diferent environments](guides-publish.md). | ||
|
||
|
||
## The manifest.json file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpierre We will likely want to update this soon.
@delfipolito @owisixseven What do you think about making it easier to access the guides / tutorials from the home page? From a first glance, it's hard to know these guides even exist, and you have to click to one of the specific areas (e.g. aragonCLI) and look at the sidebar to know that these guides exist. I had a hard time finding them even though I knew they were there somewhere 😅. |
Good point @sohkai let me work on it! |
close #15, #33, #53 , #70, #74, #76 , #77
This PR will be used to commit the changes listed in #87
@delfipolito @sohkai @0x6431346e I would like to have your feedback about adding a new section including different Guides