Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check Your First Aragon App #15

Closed
sohkai opened this issue May 31, 2018 · 1 comment · Fixed by #99
Closed

Sanity check Your First Aragon App #15

sohkai opened this issue May 31, 2018 · 1 comment · Fixed by #99
Assignees
Labels
priority: high used to mark an issue as high priority in a way that is less likely to get lost in the shuffle of th

Comments

@sohkai
Copy link
Contributor

sohkai commented May 31, 2018

There's a few things that are confusing, e.g. are we using the bare or react boilerplate? Or are we getting them to make the contracts themselves?

@sohkai sohkai self-assigned this May 31, 2018
@cjyabraham cjyabraham assigned 0xGabi and unassigned sohkai Jan 11, 2019
@cjyabraham cjyabraham added the priority: high used to mark an issue as high priority in a way that is less likely to get lost in the shuffle of th label Jan 11, 2019
@cjyabraham
Copy link
Contributor

I'm closing #69 since this issue is very similar. So you can create a new boilerplate for the tutorial or don't use one at all... whatever makes the most sense for the tutorial.

unixpi added a commit to unixpi/hack that referenced this issue May 19, 2019
0xGabi pushed a commit that referenced this issue May 22, 2019
* Update github-guide.md

Minor edits (tone + grammar)

* Add a couple of HQ images for testing

* Replace first three images

* Add a couple more hq images

* Replace remaining images in 'Editing a document on GitHub' subsection

* Add replacement images for 'Your first edit' subsection

* Delete gh-5-hq.png

Wrong folder

* Delete gh-6-hq.png

Wrong folder

* Add replacement images for 'Your first edit' subsection (correct folder)

* Edit 'Your first edit subsection' and link to replacement images

* Add replacement images for 'Proposing the file change' and 'Comparing changes' subsections

* Link to replacement images in 'Proposing the file change' and 'Comparing changes' subsections + minor edit

* Add replacement images for 'Your first pull request' subsection

* Add links to replacement images in 'Your first pull request' subsection + minor edits

* Add replacement images for 'Adjusting your pull request' subsection

* Add final links to replacement images + minor edits

* Halve width of zoomed in images

* Delete gh-0.png

* Delete gh-1.png

* Delete gh-10.png

* Delete gh-11.png

* Delete gh-12.png

* Delete gh-13.png

* Delete gh-14.png

* Delete gh-15.png

* Delete gh-16.png

* Delete gh-17.png

* Delete gh-18.png

* Delete gh-19.png

* Delete gh-2.png

* Delete gh-20.png

* Delete gh-3.png

* Delete gh-4.png

* Delete gh-5.png

* Delete gh-6.png

* Delete gh-7.png

* Delete gh-8.png

* Delete gh-9.png

* Center img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high used to mark an issue as high priority in a way that is less likely to get lost in the shuffle of th
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants