Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix like hovering state in dark mode #1363

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

lakshmi930
Copy link
Contributor

Copy link

vercel bot commented Oct 21, 2024

@lakshmi930 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@lakshmi930
Copy link
Contributor Author

Is it okay to push small lint fix also in the same PR even though it's a different file?

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lakshmi930 !

@lakshmi930
Copy link
Contributor Author

Thanks @lakshmi930 !

Thank you, I have also pushed a small lint fix! Please merge them when you've reviewed the changes. I believe I can't merge them.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.45%. Comparing base (567c01e) to head (2e4e080).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   34.15%   33.45%   -0.71%     
==========================================
  Files          63       64       +1     
  Lines        3200     3273      +73     
==========================================
+ Hits         1093     1095       +2     
- Misses       2107     2178      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dartpain dartpain merged commit 741ab6e into arc53:main Oct 23, 2024
5 of 7 checks passed
@lakshmi930 lakshmi930 deleted the ln/fix-like-hover-dark branch October 24, 2024 13:48
@dartpain
Copy link
Contributor

dartpain commented Nov 8, 2024

@holopin-bot @lakshmi930 Thank you!

Copy link

holopin-bot bot commented Nov 8, 2024

Congratulations @lakshmi930, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qmhvs74220cl8tra9h2kw

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Like Feedback hover not working
3 participants