Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #1593

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Upcoming Release Changes #1593

merged 1 commit into from
Aug 22, 2024

Conversation

theguild-bot
Copy link
Collaborator

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

  • #1592
    71c79c6
    Thanks @ardatan! - When cURL is used as the HTTP client
    implementation instead of node:http, SSL_VERIFYPEER should be set false when the
    NODE_TLS_REJECT_UNAUTHORIZED environment variable is set to 0. CAINFO should be set to the
    value of the NODE_EXTRA_CA_CERTS environment variable.

    This allows the cURL client to use the same CA certificates and SSL configuration as node:http

  • #1592
    71c79c6
    Thanks @ardatan! - When agent is provided in Request, use
    node:http instead of node-libcurl

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from c88dad0 to ba209ff Compare August 22, 2024 10:02
@theguild-bot theguild-bot force-pushed the changeset-release/master branch from ba209ff to 4253eb9 Compare August 22, 2024 10:03
Copy link
Contributor

github-actions bot commented Aug 22, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.030446 min=15      med=139     max=186      p(90)=160     p(95)=166    
     data_received..................: 23 MB  763 kB/s
     data_sent......................: 15 MB  494 kB/s
     http_req_blocked...............: avg=2.2µs      min=631ns   med=1.38µs  max=15.07ms  p(90)=2µs     p(95)=2.3µs  
     http_req_connecting............: avg=239ns      min=0s      med=0s      max=6.72ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.98ms    min=3.16ms  med=19.37ms max=956.54ms p(90)=25.31ms p(95)=27.36ms
       { expected_response:true }...: avg=19.98ms    min=3.16ms  med=19.37ms max=956.54ms p(90)=25.31ms p(95)=27.36ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 149633
     http_req_receiving.............: avg=34.04µs    min=9.07µs  med=22.66µs max=30.67ms  p(90)=38.07µs p(95)=46.24µs
     http_req_sending...............: avg=10.73µs    min=3.22µs  med=6.35µs  max=14.43ms  p(90)=9.62µs  p(95)=13.95µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.94ms    min=2.94ms  med=19.34ms max=956.46ms p(90)=25.26ms p(95)=27.28ms
     http_reqs......................: 149633 4986.881666/s
     iteration_duration.............: avg=40.07ms    min=11.11ms med=38.61ms max=976.87ms p(90)=44.32ms p(95)=49.91ms
     iterations.....................: 74787  2492.457674/s
     vus............................: 1      min=1         max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Aug 22, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.723845 min=103    med=138     max=200      p(90)=161     p(95)=166    
     data_received..................: 22 MB  746 kB/s
     data_sent......................: 14 MB  478 kB/s
     http_req_blocked...............: avg=4.35µs     min=611ns  med=1.2µs   max=12.59ms  p(90)=1.94µs  p(95)=2.17µs 
     http_req_connecting............: avg=2.26µs     min=0s     med=0s      max=7.84ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.44ms    min=2.53ms med=19.85ms max=188.09ms p(90)=25.81ms p(95)=28.51ms
       { expected_response:true }...: avg=20.44ms    min=2.53ms med=19.85ms max=188.09ms p(90)=25.81ms p(95)=28.51ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 146262
     http_req_receiving.............: avg=31.12µs    min=8.83µs med=22.04µs max=20.4ms   p(90)=36.13µs p(95)=42.33µs
     http_req_sending...............: avg=9.87µs     min=3.16µs med=5.56µs  max=25.08ms  p(90)=9.15µs  p(95)=12.16µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.4ms     min=2.49ms med=19.82ms max=187.61ms p(90)=25.77ms p(95)=28.41ms
     http_reqs......................: 146262 4874.986444/s
     iteration_duration.............: avg=40.99ms    min=15.2ms med=39.51ms max=221.39ms p(90)=46.27ms p(95)=52.67ms
     iterations.....................: 73111  2436.826612/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Aug 22, 2024

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 295552      ✗ 0     
     data_received..................: 29 MB   970 kB/s
     data_sent......................: 12 MB   394 kB/s
     http_req_blocked...............: avg=1.38µs   min=872ns    med=1.19µs   max=290.8µs  p(90)=1.86µs   p(95)=2.03µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=122.5µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=141.86µs min=95.54µs  med=136.25µs max=7.85ms   p(90)=157.46µs p(95)=164.02µs
       { expected_response:true }...: avg=141.86µs min=95.54µs  med=136.25µs max=7.85ms   p(90)=157.46µs p(95)=164.02µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 147776
     http_req_receiving.............: avg=24.5µs   min=12.32µs  med=23.46µs  max=514.01µs p(90)=30.11µs  p(95)=32.23µs 
     http_req_sending...............: avg=6.15µs   min=3.98µs   med=5.41µs   max=188.49µs p(90)=8µs      p(95)=8.56µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=111.2µs  min=70.39µs  med=105.16µs max=7.75ms   p(90)=123.52µs p(95)=128.78µs
     http_reqs......................: 147776  4925.689664/s
     iteration_duration.............: avg=198.69µs min=138.77µs med=192.18µs max=7.98ms   p(90)=216.71µs p(95)=225.71µs
     iterations.....................: 147776  4925.689664/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Aug 22, 2024

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 213640      ✗ 0     
     data_received..................: 22 MB   716 kB/s
     data_sent......................: 8.5 MB  285 kB/s
     http_req_blocked...............: avg=1.53µs   min=942ns    med=1.3µs    max=286.74µs p(90)=2.06µs   p(95)=2.27µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=119.19µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=216.71µs min=162.33µs med=201.76µs max=66.6ms   p(90)=227.77µs p(95)=237.97µs
       { expected_response:true }...: avg=216.71µs min=162.33µs med=201.76µs max=66.6ms   p(90)=227.77µs p(95)=237.97µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 106820
     http_req_receiving.............: avg=26.35µs  min=14.21µs  med=24.91µs  max=4.25ms   p(90)=32.12µs  p(95)=34.14µs 
     http_req_sending...............: avg=6.67µs   min=4.19µs   med=6.17µs   max=742.47µs p(90)=8.44µs   p(95)=9.27µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=183.68µs min=133.45µs med=168.6µs  max=66.51ms  p(90)=191.46µs p(95)=200.7µs 
     http_reqs......................: 106820  3560.515083/s
     iteration_duration.............: avg=276.21µs min=211.56µs med=260.4µs  max=66.78ms  p(90)=290.1µs  p(95)=302.94µs
     iterations.....................: 106820  3560.515083/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Aug 22, 2024

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 229072      ✗ 0     
     data_received..................: 23 MB   767 kB/s
     data_sent......................: 9.2 MB  305 kB/s
     http_req_blocked...............: avg=1.4µs    min=932ns    med=1.22µs   max=208.65µs p(90)=1.88µs   p(95)=2.03µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=122.3µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=200.71µs min=144.05µs med=188.27µs max=17.28ms  p(90)=213.76µs p(95)=222.69µs
       { expected_response:true }...: avg=200.71µs min=144.05µs med=188.27µs max=17.28ms  p(90)=213.76µs p(95)=222.69µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 114536
     http_req_receiving.............: avg=25.58µs  min=13.32µs  med=24.08µs  max=505.07µs p(90)=31.31µs  p(95)=33.36µs 
     http_req_sending...............: avg=6.32µs   min=4.12µs   med=5.54µs   max=288.18µs p(90)=8.22µs   p(95)=8.69µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=168.8µs  min=125.76µs med=156.22µs max=17.2ms   p(90)=178.34µs p(95)=186.66µs
     http_reqs......................: 114536  3817.747229/s
     iteration_duration.............: avg=257.54µs min=188.4µs  med=244.51µs max=17.41ms  p(90)=273.12µs p(95)=284.24µs
     iterations.....................: 114536  3817.747229/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Aug 22, 2024

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.5.25-rc-20240822101040-4253eb944cde9d29e809bb4dcabe233d60536c20 npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit ccce8b4 into master Aug 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants