Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] server: Skip responses without user ids when indexing #5093

Conversation

frascuchon
Copy link
Member

Pull Request Template

Since the user_id is a nullable column, the search engine must tackle responses for those scenarios. This PR changes the search engine and skips responses when the user_id is None.

This can be tackled in a better way in the future once we have a clearer view of how to deal with deleted users.

Refs: #5070

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested review from jfcalvo and burtenshaw June 21, 2024 13:15
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5093-ki24f765kq-no.a.run.app

@frascuchon frascuchon merged commit 1361bf1 into feat/argilla/manage-responses-for-deleted-users Jun 25, 2024
20 checks passed
@frascuchon frascuchon deleted the bugfix/server/skip-responses-without-user-ids branch June 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants