Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Skip responses with deleted users when log records #5095

Closed
wants to merge 4 commits into from
Closed

[BUGFIX] Skip responses with deleted users when log records #5095

wants to merge 4 commits into from

Conversation

frascuchon
Copy link
Member

Note

This change needs #5093 to be merged first

This PR fixes problems when updating records with fetched responses with deleted user_ids

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested review from burtenshaw and jfcalvo June 21, 2024 14:52
@frascuchon frascuchon mentioned this pull request Jun 21, 2024
Closed
13 tasks
@frascuchon
Copy link
Member Author

Won't apply. See #5126

@frascuchon frascuchon closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtenshaw burtenshaw Awaiting requested review from burtenshaw

@jfcalvo jfcalvo Awaiting requested review from jfcalvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frascuchon