Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #51: Fix notification boxes after redesign #82

Merged
merged 6 commits into from
Aug 30, 2017
Merged

Issue #51: Fix notification boxes after redesign #82

merged 6 commits into from
Aug 30, 2017

Conversation

wokeGit
Copy link
Contributor

@wokeGit wokeGit commented Aug 29, 2017

Fixed #51

@wokeGit wokeGit requested a review from rpelczar August 29, 2017 10:23
@wokeGit wokeGit self-assigned this Aug 29, 2017
@wokeGit wokeGit mentioned this pull request Aug 29, 2017
Closed
alexmt
alexmt requested changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in layout.html looks ok. It seems like package.json was not updated. Please run

npm install --save git+https://github.com/argoproj/ui-lib.git#v1.0.6

It will update package.json and regenerate shrinkwrap file.

@wokeGit
Copy link
Contributor Author

wokeGit commented Aug 30, 2017

Done but it only update from parameter. The commit and version is still the same.

"argo-ui-lib": {
        "version": "1.0.5",
 -      "from": "git+https://github.com/argoproj/ui-lib.git#v1.0.5",
 +      "from": "git+https://github.com/argoproj/ui-lib.git#v1.0.6",
        "resolved": "git+https://github.com/argoproj/ui-lib.git#f78f15c6c2f566534798a36d5eb211eaae36fb73"
      },

@wokeGit wokeGit changed the title Fix notification boxes after redesign Issue #51: Fix notification boxes after redesign Aug 30, 2017
@alexmt alexmt merged commit 5de5e0c into argoproj:master Aug 30, 2017
wokeGit added a commit to wokeGit/argo that referenced this pull request Nov 20, 2017
@wokeGit
Issue argoproj#51: Fix notification boxes after redesign (argoproj#82)
d34230b 
* argoproj#51 Fix for notification boxes. Moves boxes on top of top bar and adjust to redesigned top bar.

* Update ui-lib version to 1.0.6
wokeGit added a commit to wokeGit/argo that referenced this pull request Nov 21, 2017
@wokeGit
Issue argoproj#51: Fix notification boxes after redesign (argoproj#82)
356c135 
* argoproj#51 Fix for notification boxes. Moves boxes on top of top bar and adjust to redesigned top bar.

* Update ui-lib version to 1.0.6
wokeGit added a commit to wokeGit/argo that referenced this pull request Nov 22, 2017
@wokeGit
Issue argoproj#51: Fix notification boxes after redesign (argoproj#82)
510a4fb 
* argoproj#51 Fix for notification boxes. Moves boxes on top of top bar and adjust to redesigned top bar.

* Update ui-lib version to 1.0.6
icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this pull request Jan 5, 2022
@shrinandj @magaldima
Execute filterData only if data filter is specified. (argoproj#83)
38548a7 
Fixed unit tests.

Testing Done:

1. Unit tests pass
2. Added an example sensor. It failed prior to this change. Succeeded after.

Closes argoproj#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@rpelczar rpelczar Awaiting requested review from rpelczar

@felixApplatix felixApplatix Awaiting requested review from felixApplatix

Assignees

@wokeGit wokeGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wokeGit @alexmt