Issue #44: Redesign forgot/reset/confirm pages #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
felixApplatix
suggested changes
Aug 29, 2017
felixApplatix
approved these changes
Aug 29, 2017
|
@felixApplatix Good you found it. I see it is general issue and we just validate if password contains any of uppercase or lowercase letters. Our requirement is to have uppercase AND lowercase letters. |
…ppercase AND lowercase letters.
wokeGit
changed the title
alexmt
approved these changes
Aug 30, 2017
wokeGit
added a commit
to wokeGit/argo
that referenced
this pull request
Nov 20, 2017
* argoproj#44 Redesign sign-up page * argoproj#44 Redesign forgot password page * argoproj#44 Redesign confirm forgot password page * argoproj#44 Redesign confirm reset password page * argoproj#44 Redesign reset password page. Adjust buttons and cleanup. * argoproj#44 Redesign confirm setup page * argoproj#44 Adjust boxes to small screens * argoproj#44 Update custom regexp validator to allow only texts with uppercase AND lowercase letters.
wokeGit
added a commit
to wokeGit/argo
that referenced
this pull request
Nov 21, 2017
* argoproj#44 Redesign sign-up page * argoproj#44 Redesign forgot password page * argoproj#44 Redesign confirm forgot password page * argoproj#44 Redesign confirm reset password page * argoproj#44 Redesign reset password page. Adjust buttons and cleanup. * argoproj#44 Redesign confirm setup page * argoproj#44 Adjust boxes to small screens * argoproj#44 Update custom regexp validator to allow only texts with uppercase AND lowercase letters.
wokeGit
added a commit
to wokeGit/argo
that referenced
this pull request
Nov 22, 2017
* argoproj#44 Redesign sign-up page * argoproj#44 Redesign forgot password page * argoproj#44 Redesign confirm forgot password page * argoproj#44 Redesign confirm reset password page * argoproj#44 Redesign reset password page. Adjust buttons and cleanup. * argoproj#44 Redesign confirm setup page * argoproj#44 Adjust boxes to small screens * argoproj#44 Update custom regexp validator to allow only texts with uppercase AND lowercase letters.
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Fixed unit tests. Testing Done: 1. Unit tests pass 2. Added an example sensor. It failed prior to this change. Succeeded after. Closes argoproj#82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #44