Strikethrough: fix exponential backtracking #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long sequence of backslashes inside a strikethrough could confuse the strikethrough regex into exponential backtracking, causing a potential ReDoS vulnerability. This commit updates the strikethrough regex to only accept a backslash if it is preceding an escaped character, as other rules handle backslashes. Updates to version 0.7.3 to publish this fix. Thanks to @pwntester and the [GitHub Security Lab team](https://securitylab.github.com/) for finding this vulnerability! Test plan: 1. `make test` * verify the new strikethrough backtracking test passes * verify all the prior tests pass
ariabuckles
force-pushed
the
fix-strikethrough-vuln
branch
from
7d9a3cc to
1c9f675
Compare
|
Sorry I missed your name when I first read the report, but thanks for testing and finding this @erik-krogh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long sequence of backslashes inside a strikethrough could confuse the
strikethrough regex into exponential backtracking, causing a potential
ReDoS vulnerability.
This commit updates the strikethrough regex to only accept a backslash
if it is preceding an escaped character, as other rules handle
backslashes.
Updates to version 0.7.3 to publish this fix.
Thanks to @erik-krogh , @pwntester and the rest of the
GitHub Security Lab team
for finding this vulnerability!
Test plan:
make test