Update Vulkan-Headers to 1.2.174 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This static content is better kept in the platform_types.rs file only, where it can be edited directly. (Perhaps we should be more clear about generated versus manual files within the ash crate, by storing generated outputs in an auto/ module/subdirectory that is reexported, like glib and friends?)
2 tasks
This was referenced May 10, 2021
MaikKlein
approved these changes
May 10, 2021
MarijnS95
added a commit
that referenced
this pull request
Oct 3, 2024
Long ago in #339 I added "opaque" types to ensure that pointers to it stay as pointers in FFI rather than get converted to `&mut` borrows which don't carry the load of an arbitrary pointer value to "something unknown" (= opaque). When the QNX types were added in #429 and #760 some time later, they weren't added to this list and turned into borrows making them impossible to be handled safely in user code.
MarijnS95
added a commit
that referenced
this pull request
Oct 3, 2024
Long ago in #339 I added "opaque" types to ensure that pointers to it stay as pointers in FFI rather than get converted to `&mut` borrows which don't carry the load of an arbitrary pointer value to "something unknown" (= opaque). When the QNX types were added in #429 and #760 some time later, they weren't added to this list and turned into borrows making them impossible to be handled safely in user code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for upcoming churn, update all the way to .174 first.
Notable changes include some cleanup on the
nomC-parser side and keepingplatform_types.rschecked in to git instead of being static content and noise in the generator.Perhaps for this to work we need to adopt a model similar to gtk-rs/gstreamer-rs/gir, where autogenerated files reside in an
auto/subdirectory to make this clear, which is simply reexported in the right place.