Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining identifier macro issues #816

Closed
dpk opened this issue Mar 15, 2022 · 1 comment
Closed

Remaining identifier macro issues #816

dpk opened this issue Mar 15, 2022 · 1 comment

Comments

@dpk
Copy link
Contributor

dpk commented Mar 15, 2022

  • (chibi syntax-case) still tries to import make-variable-transformer from (chibi) rather than (chibi ast) (this is my fault for forgetting that module still depends on make-variable-transformer even though identifier-syntax is gone from it!)

  • identifier-syntax is still broken since the change to syntax-rules in 4382b9d:

    (import (chibi ast))
    (define-syntax foo (identifier-syntax (_ 'ref) ((set! _ _) 'set)))
    foo ;=> ERROR: cdr: not a pair: foo
    (foo) ;=> ERROR: non procedure application: ref (this is correct, but the next line isn’t)
    (foo x y) ;=> set
@dpk
Copy link
Contributor Author

dpk commented Mar 15, 2022

Also, make test-all still doesn’t include tests/syntax-tests.scm, which would have caught the second problem clearly.

ashinn added a commit that referenced this issue Mar 15, 2022
@ashinn ashinn closed this as completed in c28bbba Mar 17, 2022
ashinn added a commit that referenced this issue Mar 17, 2022
Fix definition of full-match? (Proposed fix for #816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant