Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of full-match? (Proposed fix for #816) #818

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

dpk
Copy link
Contributor

@dpk dpk commented Mar 16, 2022

Full matching applies for all syntax rules if any of the syntax patterns is not a pair. Maintains the old behaviour for conformant R7RS syntax-rules macros (without breaking the count-to-2_ test), but also allows identifier macros, and fully fixes identifier-syntax.

@dpk dpk force-pushed the fix-identifier-syntax branch from 24f4c77 to c28bbba Compare March 16, 2022 08:16
@ashinn
Copy link
Owner

ashinn commented Mar 16, 2022

Thanks Daphne, this is simpler than what I had in mind. I guess it won't work if they try to write a set! macro without ref support, but nobody would do that. Let me take a look.

@ashinn ashinn merged commit 1d8bd4a into ashinn:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants