-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade bazel to v7.3.2 #1969
Conversation
TestAll tests were cache hits 203 tests (100.0%) were fully cached saving 39s. Teste2e/bzlmodAll tests were cache hits 5 tests (100.0%) were fully cached saving 789ms. Teste2e/gyp_no_install_scriptAll tests were cache hits 2 tests (100.0%) were fully cached saving 169ms. Teste2e/js_image_ociAll tests were cache hits 1 test (100.0%) was fully cached saving 8s. Teste2e/npm_link_packageAll tests were cache hits 3 tests (100.0%) were fully cached saving 920ms. Teste2e/npm_link_package-esmAll tests were cache hits 3 tests (100.0%) were fully cached saving 924ms. Teste2e/npm_translate_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 27ms. Teste2e/npm_translate_lock_emptyAll tests were cache hits 1 test (100.0%) was fully cached saving 27ms. Teste2e/npm_translate_lock_multiAll tests were cache hits 2 tests (100.0%) were fully cached saving 296ms. Teste2e/npm_translate_lock_partial_cloneAll tests were cache hits 1 test (100.0%) was fully cached saving 112ms. Teste2e/npm_translate_lock_replace_packagesAll tests were cache hits 3 tests (100.0%) were fully cached saving 233ms. Teste2e/npm_translate_lock_subdir_patchAll tests were cache hits 1 test (100.0%) was fully cached saving 236ms. Teste2e/npm_translate_package_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 81ms. Teste2e/npm_translate_yarn_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 81ms. Teste2e/package_json_moduleAll tests were cache hits 1 test (100.0%) was fully cached saving 504ms. Teste2e/pnpm_lockfilesAll tests were cache hits 40 tests (100.0%) were fully cached saving 3s. Teste2e/pnpm_workspaceBuildkite build #6433 is running... Teste2e/pnpm_workspace_rerootedAll tests were cache hits 12 tests (100.0%) were fully cached saving 3s. Teste2e/repo_mappingAll tests were cache hits 2 tests (100.0%) were fully cached saving 493ms. Teste2e/rules_fooAll tests were cache hits 2 tests (100.0%) were fully cached saving 153ms. Teste2e/runfilesAll tests were cache hits 1 test (100.0%) was fully cached saving 413ms. Teste2e/vendored_nodeAll tests were cache hits 1 test (100.0%) was fully cached saving 171ms. Buildifier Format |
85b2dd3
to
9f2e0b6
Compare
@gregmagolan with my additional XDG commit in this PR along with #1986 (non-bzlmod runfiles broken in bazel7) and #1987 (bazel-lib missing a fix in bzlmod) then the only remaining failures should be the windows ones. |
9f2e0b6
to
bfe2390
Compare
bfe2390
to
bf0a6ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the PR title?
@DavidZbarsky-at wdyt of the CI cache changes going along with the bazel upgrade? I'm not super familiar with the GH CI but it seems like the |
bf0a6ce
to
937fabf
Compare
937fabf
to
30daf89
Compare
yeah I generally don't trust tools to expand ~ consistently and it seems fine to use the default locations |
30daf89
to
4b69372
Compare
Note the "Post Mount bazel caches" CI step is taking forever 🤔 |
4b69372
to
3d6c0bd
Compare
XDG_CACHE_HOME is also problematic for other reasons: bazel-contrib/bazel-lib#914 (comment) |
No description provided.