Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to Bazel 7.3.1 #914

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: bump to Bazel 7.3.1 #914

merged 1 commit into from
Aug 20, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Aug 20, 2024

No description provided.

@gregmagolan gregmagolan enabled auto-merge (squash) August 20, 2024 03:20
Copy link

aspect-workflows bot commented Aug 20, 2024

Test

4 test targets passed

Targets
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]    233ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild] 208ms
//lib/tests/jq:check_stamped [k8-fastbuild]                  363ms
//lib/tests/yq:check_stamped [k8-fastbuild]                  360ms

Total test execution time was 1s. 217 tests (98.2%) were fully cached saving 31s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the bump_bazel branch 2 times, most recently from 7494c18 to d3f5093 Compare August 20, 2024 03:59
@gregmagolan gregmagolan changed the title chore: bump to Bazel 7.3.1 chore: bump to Bazel 7.2.1 Aug 20, 2024
@gregmagolan gregmagolan force-pushed the bump_bazel branch 2 times, most recently from e0e937a to 0672ad0 Compare August 20, 2024 04:07
@gregmagolan gregmagolan marked this pull request as draft August 20, 2024 04:07
auto-merge was automatically disabled August 20, 2024 04:07

Pull request was converted to draft

@gregmagolan
Copy link
Collaborator Author

gregmagolan commented Aug 20, 2024

Getting strange failures on GitHub Actions ephemeral runners compiling tools/cpp/runfiles/runfiles.cc on attempted bumps to 7.2.1 and 7.3.1:

(04:00:05) ERROR: /home/runner/work/bazel-lib/bazel-lib/e2e/copy_action/~/.cache/xdg-cache/bazel/_bazel_runner/62e983f9dcfd129cff412924cb4ab3e8/external/bazel_tools/tools/cpp/runfiles/BUILD:3:11: Compiling ~/.cache/xdg-cache/bazel/_bazel_runner/62e983f9dcfd129cff412924cb4ab3e8/external/bazel_tools/tools/cpp/runfiles/runfiles.cc failed: (Exit 1): gcc failed: error executing CppCompile command (from target //~/.cache/xdg-cache/bazel/_bazel_runner/62e983f9dcfd129cff412924cb4ab3e8/external/bazel_tools/tools/cpp/runfiles:runfiles) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++14' -MD -MF ... (remaining 16 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
~/.cache/xdg-cache/bazel/_bazel_runner/62e983f9dcfd129cff412924cb4ab3e8/external/bazel_tools/tools/cpp/runfiles/runfiles.cc:17:10: fatal error: tools/cpp/runfiles/runfiles.h: No such file or directory
   17 | #include "tools/cpp/runfiles/runfiles.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Attempted bump to 7.2.0 had different strange failure:

(04:08:45) ERROR: /home/runner/work/bazel-lib/bazel-lib/e2e/copy_action/~/.cache/xdg-cache/bazel/_bazel_runner/install/78ccbcf59b0fe2de7bbdccc470af78df/rules_java/java/BUILD:29:12: no such package 'java/common': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /home/runner/work/bazel-lib/bazel-lib/e2e/copy_action/java/common and referenced by '//~/.cache/xdg-cache/bazel/_bazel_runner/install/78ccbcf59b0fe2de7bbdccc470af78df/rules_java/java:core_rules'
(04:08:44) ERROR: /home/runner/work/bazel-lib/bazel-lib/e2e/copy_action/~/.cache/xdg-cache/bazel/_bazel_runner/install/78ccbcf59b0fe2de7bbdccc470af78df/embedded_tools/tools/BUILD:75:10: no such package 'tools/sh': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /home/runner/work/bazel-lib/bazel-lib/e2e/copy_action/tools/sh and referenced by '//~/.cache/xdg-cache/bazel/_bazel_runner/install/78ccbcf59b0fe2de7bbdccc470af78df/embedded_tools/tools:bzl_srcs'

@gregmagolan gregmagolan changed the title chore: bump to Bazel 7.2.1 chore: bump to Bazel 7.2.0 Aug 20, 2024
@gregmagolan gregmagolan changed the title chore: bump to Bazel 7.2.0 chore: bump to Bazel 7.3.1 Aug 20, 2024
lib/private/BUILD.bazel Outdated Show resolved Hide resolved
@gregmagolan gregmagolan force-pushed the bump_bazel branch 6 times, most recently from d920701 to bd3040b Compare August 20, 2024 15:12
@gregmagolan gregmagolan marked this pull request as ready for review August 20, 2024 15:15
@gregmagolan
Copy link
Collaborator Author

Getting strange failures on GitHub Actions ephemeral runners compiling tools/cpp/runfiles/runfiles.cc on attempted bumps to 7.2.1 and 7.3.1

Resolved by not setting XDG_CACHE_HOME env.

Setting XDG_CACHE_HOME breaks the build as of Bazel 7.2.0 due to

Bazel on Linux and BSD now respects the XDG_CACHE_HOME environment variable instead of assuming that ~/.cache/bazel is writable. (#21817)

https://github.com/bazelbuild/bazel/releases/tag/7.2.0

See https://bazelbuild.slack.com/archives/CA31HN1T3/p1718650523156059 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants