Revert "feat: introduce skip_lib_check attribute (#345)" (#347)

This reverts commit 1a07af0.
aspect-build · Apr 1, 2023 · dab5e3f · dab5e3f
1 parent 1a07af0
commit dab5e3f
Show file tree

Hide file tree

Showing 14 changed files with 6 additions and 82 deletions.
diff --git a/docs/rules.md b/docs/rules.md
diff --git a/e2e/test/common.bats b/e2e/test/common.bats
@@ -155,7 +155,6 @@ ts_project(
     out_dir = "${out_dir}",
     deps = [${deps_joined}],
     args = [${args_joined}],
-    skip_lib_check = False,
     $source_map
     $declaration
     $composite

diff --git a/examples/skip_lib_check/off/BUILD.bazel b/examples/skip_lib_check/off/BUILD.bazel
diff --git a/examples/skip_lib_check/off/source.ts b/examples/skip_lib_check/off/source.ts
diff --git a/examples/skip_lib_check/off/tsconfig.json b/examples/skip_lib_check/off/tsconfig.json
diff --git a/examples/skip_lib_check/on/BUILD.bazel b/examples/skip_lib_check/on/BUILD.bazel
diff --git a/examples/skip_lib_check/on/source.ts b/examples/skip_lib_check/on/source.ts
diff --git a/examples/skip_lib_check/on/tsconfig.json b/examples/skip_lib_check/on/tsconfig.json
diff --git a/examples/skip_lib_check/unspecified/BUILD.bazel b/examples/skip_lib_check/unspecified/BUILD.bazel
diff --git a/examples/skip_lib_check/unspecified/source.ts b/examples/skip_lib_check/unspecified/source.ts
diff --git a/examples/skip_lib_check/unspecified/tsconfig.json b/examples/skip_lib_check/unspecified/tsconfig.json
diff --git a/ts/defs.bzl b/ts/defs.bzl
@@ -66,7 +66,6 @@ def ts_project(
         composite = False,
         incremental = False,
         emit_declaration_only = False,
-        skip_lib_check = True,
         transpiler = None,
         ts_build_info_file = None,
         tsc = _tsc,
@@ -232,10 +231,6 @@ def ts_project(
             Instructs Bazel to expect a `.tsbuildinfo` output.
         emit_declaration_only: Whether the `emitDeclarationOnly` bit is set in the tsconfig.
             Instructs Bazel *not* to expect `.js` or `.js.map` outputs for `.ts` sources.
-        skip_lib_check: Whether skip type checking of declaration files. 
-            This can save time during compilation at the expense of type-system accuracy. 
-            For example, two libraries could define two copies of the same type in an inconsistent way. 
-            Rather than doing a full check of all d.ts files, TypeScript will type check the code you specifically refer to in your app’s source code.
         ts_build_info_file: The user-specified value of `tsBuildInfoFile` from the tsconfig.
             Helps Bazel to predict the path where the .tsbuildinfo output is written.
 
@@ -419,7 +414,6 @@ def ts_project(
         declaration_dir = declaration_dir,
         source_map = source_map,
         declaration_map = declaration_map,
-        skip_lib_check = int(skip_lib_check) if skip_lib_check != None else -1,
         out_dir = out_dir,
         root_dir = root_dir,
         js_outs = tsc_js_outs,

diff --git a/ts/private/ts_lib.bzl b/ts/private/ts_lib.bzl
@@ -117,10 +117,6 @@ COMPILER_OPTION_ATTRS = {
     "source_map": attr.bool(
         doc = "https://www.typescriptlang.org/tsconfig#sourceMap",
     ),
-    "skip_lib_check": attr.int(
-        doc = "https://www.typescriptlang.org/tsconfig#skipLibCheck", 
-        values = [-1, 0, 1]
-    )
 }
 
 # tsc knows how to produce the following kinds of output files.

diff --git a/ts/private/ts_project.bzl b/ts/private/ts_project.bzl
@@ -106,12 +106,6 @@ See https://github.com/aspect-build/rules_ts/issues/228 for more details.
             "--declarationDir",
             declaration_dir,
         ])
-
-    if ctx.attr.skip_lib_check != -1:
-        arguments.add_all([
-            "--skipLibCheck",
-            bool(ctx.attr.skip_lib_check),
-        ])
 
     # When users report problems, we can ask them to re-build with
     # --define=VERBOSE_LOGS=1