Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce skip_lib_check attribute #345

Merged
merged 3 commits into from
Mar 31, 2023
Merged

feat: introduce skip_lib_check attribute #345

merged 3 commits into from
Mar 31, 2023

Conversation

thesayyn
Copy link
Member

closes #326

Benchmark 1: bazel build examples/skip_lib_check/unspecified
  Time (abs ≡):         1.734 s               [User: 0.051 s, System: 0.060 s]
 
Benchmark 2: bazel build examples/skip_lib_check/on
  Time (abs ≡):        737.8 ms               [User: 59.2 ms, System: 50.6 ms]
 
Benchmark 3: bazel build examples/skip_lib_check/off
  Time (abs ≡):         1.180 s               [User: 0.049 s, System: 0.045 s]
 
Summary
  'bazel build examples/skip_lib_check/on' ran
    1.60 times faster than 'bazel build examples/skip_lib_check/off'
    2.35 times faster than 'bazel build examples/skip_lib_check/unspecified'

@thesayyn thesayyn requested a review from gregmagolan March 31, 2023 12:08
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple for such a large perf improvement 🚀

@gregmagolan gregmagolan merged commit 1a07af0 into main Mar 31, 2023
@gregmagolan gregmagolan deleted the skip_lib_check branch March 31, 2023 13:55
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a mistake, it makes tsc green under Bazel but red outside of Bazel in many cases. skipLibCheck is a well-understood performance tradeoff and there's lots of docs out there about adding it to tsconfig. We have never overridden tsconfig in this way before and I'd rather not start. I'll make a PR to improve this before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: add tri-state skip_lib_check attribute (True, False, None) --- change default to True
3 participants