Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Workers broken on Windows #228

Closed
1 task
alexeagle opened this issue Nov 4, 2022 · 5 comments
Closed
1 task

[Bug]: Workers broken on Windows #228

alexeagle opened this issue Nov 4, 2022 · 5 comments
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build persistent workers Bug is only reproducible when using supports_workers windows Specific to Windows

Comments

@alexeagle
Copy link
Member

alexeagle commented Nov 4, 2022

What happened?

With workers
https://buildkite.com/bazel/bcr-presubmit/builds/674#018443a2-60ec-4c83-b51b-021568de0748

(17:15:06) ERROR: C:/b/bk-windows-r2x7/bazel-downstream-projects/output/rules_ts-1.0.0-rc5/e2e/bzlmod/BUILD:4:11: Compiling TypeScript project @@//:ts [tsc -p tsconfig.json] failed: Worker process did not return a WorkResponse:
  |  
  | ---8<---8<--- Start of log, file at C:/b/kvdsqqpu/bazel-workers/worker-1-TsProject.log ---8<---8<---
  | node:internal/modules/cjs/loader:936
  | throw err;
  | ^
  |  
  | Error: Cannot find module 'google-protobuf'
  | Require stack:
  | - C:\b\kvdsqqpu\execroot\_main\bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\aspect_rules_ts~override~ext~npm_typescript\tsc_worker.bat.runfiles\aspect_rules_ts~override~ext~npm_typescript\node_modules\@bazel\worker\src\worker_protocol.js
  | - C:\b\kvdsqqpu\execroot\_main\bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\aspect_rules_ts~override~ext~npm_typescript\tsc_worker.bat.runfiles\aspect_rules_ts~override~ext~npm_typescript\node_modules\@bazel\worker\src\worker.js
  | - C:\b\kvdsqqpu\execroot\_main\bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\aspect_rules_ts~override~ext~npm_typescript\tsc_worker.bat.runfiles\aspect_rules_ts~override~ext~npm_typescript\node_modules\@bazel\worker\index.js
  | - C:\b\kvdsqqpu\execroot\_main\bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\aspect_rules_ts~override~ext~npm_typescript\tsc_worker.bat.runfiles\aspect_rules_ts~override~ext~npm_typescript\ts_project_worker.js
 

Without workers
https://buildkite.com/bazel/bcr-presubmit/builds/681#018443d0-fe66-4fd5-aa90-c872f24458f7

Version

rules_ts 1.0.0-rc5

How to reproduce

No response

Any other information?

No response

Fund our work

  • Sponsor our open source work by donating a bug bounty
@alexeagle alexeagle added the bug Something isn't working label Nov 4, 2022
@alexeagle alexeagle added this to the 1.0 milestone Nov 4, 2022
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
alexeagle added a commit that referenced this issue Nov 4, 2022
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
@alexeagle
Copy link
Member Author

@thesayyn any idea if this looks fixable this week?

@thesayyn
Copy link
Member

@thesayyn any idea if this looks fixable this week?

I missed the comment. It's less likely given that I don't have a windows machine to debug and fix.

@gregmagolan
Copy link
Member

This looks tricky. I suggest we advertise the workers are not support yet on Windows in the 1.0.0 release. #244

@gregmagolan gregmagolan removed this from the 1.0 milestone Nov 16, 2022
@gregmagolan gregmagolan changed the title [Bug]: Broken on Windows [Bug]: Workers broken on Windows Nov 16, 2022
@alexeagle
Copy link
Member Author

Still noticing that rules_ts has no windows coverage on BCR :(

@gregmagolan gregmagolan added the windows Specific to Windows label Feb 5, 2023
@gregmagolan gregmagolan added the funding needed Contribute to https://opencollective.com/aspect-build label Feb 5, 2023
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 5, 2023
@alexeagle
Copy link
Member Author

Due to bugs like this one, we are moving away from supporting the Persistent Worker in the next major 2.0 release of rules_ts, and likely will never fix this, sorry!

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Open Source Aug 8, 2023
@alexeagle alexeagle added the persistent workers Bug is only reproducible when using supports_workers label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build persistent workers Bug is only reproducible when using supports_workers windows Specific to Windows
Projects
Archived in project
Development

No branches or pull requests

3 participants