Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates for bzlmod launch #229

Merged
merged 1 commit into from
Nov 4, 2022
Merged

chore: updates for bzlmod launch #229

merged 1 commit into from
Nov 4, 2022

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle requested a review from kormide November 4, 2022 19:17
@kormide
Copy link
Member

kormide commented Nov 4, 2022 •
edited by alexeagle
Loading

Few things left to do:

  • Move bcr folder to root, change to .bcr
  • Delete bcr github actions scripts
  • Set a fixedReleaser in .bcr/config.yml

@alexeagle
Copy link
Member Author

okay I'll do those here while I'm in these files

@alexeagle alexeagle force-pushed the bzlmod5 branch 2 times, most recently from a0cb162 to 40f166b Compare November 4, 2022 19:21
kormide
kormide reviewed Nov 4, 2022
View reviewed changes
.bcr/config.yaml Outdated
@@ -0,0 +1 @@
fixedReleaser: alexeagle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema for this changed. fixedReleaser now takes login and email fields.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think the .yml extension is assumed. I should make that more flexible..

@kormide
Copy link
Member

kormide commented Nov 4, 2022

Just need to rename config.yaml -> config.yml.

@alexeagle
chore: updates for bzlmod launch
5cfc997 
- we are broken on windows, #228
- add the snippet so our next release shows how to use from BCR
@alexeagle alexeagle merged commit b7b01c2 into main Nov 4, 2022
@alexeagle alexeagle deleted the bzlmod5 branch November 4, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @kormide