Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: roll-forward a skipLibCheck performance gain for most users #348

Closed
alexeagle opened this issue Apr 1, 2023 · 0 comments · Fixed by #350
Closed

FR: roll-forward a skipLibCheck performance gain for most users #348

alexeagle opened this issue Apr 1, 2023 · 0 comments · Fixed by #350
Labels
bug Something isn't working untriaged Requires traige
Milestone
2.0

Comments

@alexeagle
Copy link
Member

What happened?

#345 was reverted, it needs a bit more design. I'll work through it w/ Sahin.

  • Default value for skipLibCheck is false per the TS team at Microsoft and it's confusing when our defaults don't match theirs.
  • There are real cases where skipLibCheck is incorrect and masks type-errors. If you ship a library, that can mean your users hit the bug.
  • We want users to be aware of this optimization and our recommendation that they elect to opt-in to it.
  • There should be a place in their codebase that "skipLibCheck" appears, in tsconfig or a config setting or something, so they can figure out they chose it

Version

HEAD

How to reproduce

No response

Any other information?

No response
@alexeagle alexeagle added the bug Something isn't working label Apr 1, 2023
@alexeagle alexeagle added this to the 2.0 milestone Apr 1, 2023
@github-actions github-actions bot added the untriaged Requires traige label Apr 1, 2023
alexeagle added a commit that referenced this issue Apr 1, 2023
@alexeagle
feat: skipLibCheck take 2
d54ee15 
Fixes #348
@alexeagle alexeagle mentioned this issue Apr 1, 2023
Merged
alexeagle added a commit that referenced this issue Apr 3, 2023
@alexeagle @thesayyn
feat: skipLibCheck take 2 (#350)
ed9d26c 
* feat: skipLibCheck take 2

Fixes #348

* refactor: use bool flags, finish error msg

* refactor: use string_flag instead of pair of bool_flag

* Update ts/defs.bzl

Co-authored-by: Sahin Yort <[email protected]>

* Update defs.bzl

---------

Co-authored-by: Sahin Yort <[email protected]>
@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged Requires traige
Projects
Open Source
Archived in project
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

feat: skipLibCheck take 2 aspect-build/rules_ts
1 participant
@alexeagle