Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Check should catch abstract additions to public classes #146

Closed
dougbu opened this issue Jan 13, 2017 · 1 comment
Closed

API Check should catch abstract additions to public classes #146

dougbu opened this issue Jan 13, 2017 · 1 comment
Assignees
@dougbu
Labels
3 - Done task
Milestone
2.0.0-preview2

Comments

@dougbu
Copy link
Member

dougbu commented Jan 13, 2017

For example, I added the abstract ShouldValidate property to ModelMetadata in aspnet/Mvc#5676. But, the AppVeyor build and all other command-line builds succeeded.

Yes, there's a bug in @dougbu as well.
@Eilon Eilon added this to the 2.0.0-preview1 milestone Apr 6, 2017
@Eilon Eilon modified the milestones: 2.0.0-preview1, 2.0.0-preview2 Apr 21, 2017
dougbu added a commit that referenced this issue May 19, 2017
@dougbu
Disallow new abstract type members
055bbc9 
- #146
- also add tests of field removals

nits:
- whitespace cleanup in `ApiListingGenerator` and `ApiListingComparerTests`
- remove unused `additionalFilters` parameter from `ApiListingComparerTests.CreateApiListingDocument()`
@dougbu dougbu mentioned this issue May 19, 2017
Closed
dougbu added a commit to aspnet/HttpAbstractions that referenced this issue May 24, 2017
@dougbu
React to breaking change latest API Check detects
24d9847 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
@dougbu dougbu mentioned this issue May 24, 2017
Closed
dougbu added a commit to aspnet/HttpAbstractions that referenced this issue May 24, 2017
@dougbu
React to breaking change latest API Check detects
7447711 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to dotnet/efcore that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
4278b5b 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
@dougbu dougbu mentioned this issue May 25, 2017
Closed
dougbu added a commit to aspnet/Mvc that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
c631907 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786
This was referenced May 25, 2017
Closed
Closed
dougbu added a commit to dotnet/efcore that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
d245ad2 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to aspnet/Mvc that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
1f88139 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786
dougbu added a commit to aspnet/Mvc that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
4e3c469 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786
dougbu added a commit to dotnet/efcore that referenced this issue May 25, 2017
@dougbu
React to breaking change latest API Check detects
85f34b6 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to aspnet/HttpAbstractions that referenced this issue May 26, 2017
@dougbu
React to breaking change latest API Check detects
fb08561 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to aspnet/Mvc that referenced this issue May 26, 2017
@dougbu
React to breaking change latest API Check detects
1a294b8 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786
dougbu added a commit that referenced this issue May 26, 2017
@dougbu
Disallow new abstract type members
3596a1f 
- #146
- also add tests of field removals

nits:
- whitespace cleanup in `ApiListingGenerator` and `ApiListingComparerTests`
- remove unused `additionalFilters` parameter from `ApiListingComparerTests.CreateApiListingDocument()`
dougbu added a commit to aspnet/HttpAbstractions that referenced this issue May 26, 2017
@dougbu
React to breaking change latest API Check detects
5b9e129 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to dotnet/efcore that referenced this issue May 26, 2017
@dougbu
React to breaking change latest API Check detects
284f1e6 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
dougbu added a commit to aspnet/Mvc that referenced this issue May 26, 2017
@dougbu
React to breaking change latest API Check detects
9f4ff22 
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786
@dougbu
Copy link
Member Author

dougbu commented May 26, 2017

@dougbu dougbu closed this as completed May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougbu dougbu

Labels
3 - Done task
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
2 participants
@Eilon @dougbu