React to breaking change latest API Check detects #8588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajcvickers was this bit of 09b1503 an intentional breaking change? If not, we should revert that before I check aspnet/BuildTools#259 in. |
|
@dougbu We review all our breaking changes through a different process, so you can assume that anything detected by the tool is intentional. |
ajcvickers
approved these changes
May 25, 2017
dougbu
force-pushed
the
dougbu/api.check.reaction
branch
from
4278b5b to
d245ad2
Compare
dougbu
force-pushed
the
dougbu/api.check.reaction
branch
from
d245ad2 to
85f34b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstracttype members aspnet/BuildTools#259 and issue API Check should catchabstractadditions topublicclasses aspnet/BuildTools#146