This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
RequireHttpsAttribute doesn't change the port #4112
Comments
Kind of related to #4093 In the default case we should indeed drop the port number when redirecting to HTTPS, and fix the offending test. |
sebastienros
added a commit
that referenced
this issue
Feb 18, 2016
sebastienros
added a commit
that referenced
this issue
Feb 18, 2016
sebastienros
added a commit
that referenced
this issue
Feb 19, 2016
sebastienros
added a commit
that referenced
this issue
Feb 20, 2016
sebastienros
added a commit
that referenced
this issue
Feb 22, 2016
sebastienros
added a commit
that referenced
this issue
Feb 23, 2016
3-Done? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
RequireHttpsAttribute changes the scheme but not the port, so
http://localhost:44380/
gets redirected tohttps://localhost:44380/
, which is invalid because you can't serve both http and https on the same port.The only way this ever worked was if the original request's host header did not include the port (e.g.
localhost
rather thanlocalhost:80
)There's even a (wrong) test:
25838ce#diff-ba666c0ff94ddf047b6f11caa0ac94c9R42
@sebastienros @blowdart @javiercn
The text was updated successfully, but these errors were encountered: