This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
[Fixes #4112 #4093] Adding support for custom SSL port #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,9 @@ | |||
| using Microsoft.AspNetCore.Mvc.Abstractions; | |||
| using Microsoft.AspNetCore.Mvc.Filters; | |||
| using Microsoft.AspNetCore.Routing; | |||
| using Microsoft.Extensions.DependencyInjection; | |||
| using Microsoft.Extensions.Options; | |||
| using System; | |||
sebastienros
force-pushed
the
sebros/requiressl
branch
2 times, most recently
from
c943458 to
49112c0
Compare
sebastienros
changed the title
| [InlineData("http://localhost:5000", null, "https://localhost/")] | ||
| [InlineData("http://[2001:db8:a0b:12f0::1]", null, "https://[2001:db8:a0b:12f0::1]/")] | ||
| [InlineData("http://[2001:db8:a0b:12f0::1]:5000", null, "https://[2001:db8:a0b:12f0::1]/")] | ||
| [InlineData("http://localhost:5000/path", null, "https://localhost/path")] |
There was a problem hiding this comment.
Can you add variation(s) having query string too?
There was a problem hiding this comment.
Thanks @sebastienros Just FYI...you seem to have squashed your commits. This makes it difficult to find the differences(to see how the feedback was addressed) from earlier commit. You could squash the commits once you get a sign off.
sebastienros
force-pushed
the
sebros/requiressl
branch
2 times, most recently
from
71893dd to
4440358
Compare
|
|
|
Looks good to me, |
| @@ -16,6 +19,8 @@ public class RequireHttpsAttributeTests | |||
| public void OnAuthorization_AllowsTheRequestIfItIsHttps() | |||
| { | |||
| // Arrange | |||
| var options = new TestOptionsManager<MvcOptions>(); | |||
|
|
sebastienros
force-pushed
the
sebros/requiressl
branch
from
4440358 to
27924ff
Compare
sebastienros
force-pushed
the
sebros/requiressl
branch
from
27924ff to
c259f82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New optional MvcOptions.SslPort. If not defined the redirection uses an empty port (default),
otherwise the custom port is used.