Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Change access modifier for InputTagHelper.GetInputType #4979

Closed
marcusien opened this issue Jul 7, 2016 · 5 comments
Closed

Change access modifier for InputTagHelper.GetInputType #4979

marcusien opened this issue Jul 7, 2016 · 5 comments
Assignees
@NTaylorMullen
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@marcusien
Copy link

For now I copied some source code from Mvc but It could be better to change private by protected on InputTagHelper for the method GetInputType
@NTaylorMullen
Copy link
Contributor

@marcusien what are you building that could use GetInputType?

@marcusien
Copy link
Author

I'm creating an InputTagHelper where I need to know which kind of input I'm facing of. I find it dumb to remake something existing in the base class.

And my need is very basic, I doubt to be the only one who needs it

@NTaylorMullen
Copy link
Contributor

Fair enough. Not a horrible idea 👍

@Eilon Eilon added this to the 1.1.0 milestone Jul 21, 2016
@Eilon
Copy link
Member

Eilon commented Jul 21, 2016

@NTaylorMullen please add some stellar doc comments to this API because it's not super clear to me what the parameters mean 😄

NTaylorMullen added a commit that referenced this issue Aug 2, 2016
@NTaylorMullen
Expose GetInputType as a protected member of InputTagHelper.
97a49f9 
- Added doc comments.

#4979
@NTaylorMullen NTaylorMullen mentioned this issue Aug 2, 2016
Merged
NTaylorMullen added a commit that referenced this issue Aug 4, 2016
@NTaylorMullen
Expose GetInputType as a protected member of InputTagHelper.
663f6a1 
- Added doc comments.

#4979
@NTaylorMullen
Copy link
Contributor

663f6a1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @NTaylorMullen @marcusien